RESOLVED FIXED 205995
<iframe> attributes should be processed on "srcdoc" attribute removal 
https://bugs.webkit.org/show_bug.cgi?id=205995
Summary <iframe> attributes should be processed on "srcdoc" attribute removal
Alexey Shvayka
Reported 2020-01-09 03:07:01 PST
Per spec, "srcdoc" attribute of an <iframe> takes precedence over "src". However, existing handling of "srcdoc" in HTMLFrameElementBase::parseAttribute does not check if the attribute was set or removed. As a result, removal of "srcdoc" attribute navigates the <iframe> to "about:srcdoc" instead of URL in value of "src" attribute. WHATWG HTML: https://html.spec.whatwg.org/multipage/iframe-embed-object.html#otherwise-steps-for-iframe-or-frame-elements
Attachments
Patch (4.29 KB, patch)
2020-01-09 03:20 PST, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2020-01-09 03:20:50 PST
Created attachment 387212 [details] Patch
WebKit Commit Bot
Comment 2 2020-01-13 23:54:36 PST
The commit-queue encountered the following flaky tests while processing attachment 387212 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2020-01-13 23:55:06 PST
Comment on attachment 387212 [details] Patch Clearing flags on attachment: 387212 Committed r254498: <https://trac.webkit.org/changeset/254498>
WebKit Commit Bot
Comment 4 2020-01-13 23:55:08 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-01-13 23:56:15 PST
<rdar://problem/58559565>
Note You need to log in before you can comment on or make changes to this bug.