Bug 205980 - Set the title for images so it will be correctly displayed in UIContextMenus
Summary: Set the title for images so it will be correctly displayed in UIContextMenus
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-08 18:15 PST by Megan Gardner
Modified: 2020-01-09 13:10 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2020-01-08 18:16 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (1.82 KB, patch)
2020-01-09 11:30 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-01-08 18:15:41 PST 
Set the title for images so it will be correctly displayed in UIContextMenus
Comment 1 Megan Gardner 2020-01-08 18:16:51 PST 
Created attachment 387175 [details]
Patch
Comment 2 Megan Gardner 2020-01-08 18:17:46 PST 
<rdar://problem/57701988>
Comment 3 Tim Horton 2020-01-08 23:02:59 PST 
Comment on attachment 387175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387175&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8483
> +                return [UIMenu menuWithTitle:[elementInfo title] children:actions];

I still maintain you should use positionInfo here, not the API wrapper :)
Comment 4 Megan Gardner 2020-01-09 11:30:44 PST 
Created attachment 387248 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2020-01-09 13:10:24 PST 
Comment on attachment 387248 [details]
Patch for landing

Clearing flags on attachment: 387248

Committed r254292: <https://trac.webkit.org/changeset/254292>
Comment 6 WebKit Commit Bot 2020-01-09 13:10:26 PST 
All reviewed patches have been landed.  Closing bug.