Bug 205963 – Resource Load Statistics: Flip experimental cookie blocking setting from an enable to a disable

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Wilander]

To get default on behavior, experimental features in the network process need to be turned from enable to disable flags. We should do that for the experimental cookie blocking setting.

[Radar WebKit Bug Importer]

<rdar://problem/58424136>

[John Wilander]

Created attachment 387149 [details]
Patch

[Brent Fulgham]

Comment on attachment 387149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387149&action=review

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:75
> +    auto thirdPartyCookieBlockingMode = WebCore::ThirdPartyCookieBlockingMode::All;

When would we ever hit 'OnlyAccordingToPerDomainPolicy'?

[John Wilander]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 387149 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387149&action=review
> 
> > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:75
> > +    auto thirdPartyCookieBlockingMode = WebCore::ThirdPartyCookieBlockingMode::All;
> 
> When would we ever hit 'OnlyAccordingToPerDomainPolicy'?

It was the old default but now it's only needed to be able to run layout tests with non-ITP behavior by default. The TestRunner falls back to this old setting for all tests that don't explicitly test ITP's behavior. Otherwise a bunch of tests that assume cookie access would not pass.

My reasoning is that since users can turn off ITP and WKWebViews don't run with ITP, the rest of the layout test suite needs to continue testing under such conditions.

(Per-domain policy effectively means that if the layout test doesn't make a domain prevalent, ITP won't do anything, ergo non-ITP behavior.)

I hope this makes sense.

Thanks for the review!

[WebKit Commit Bot]

Comment on attachment 387149 [details]
Patch

Clearing flags on attachment: 387149

Committed r254239: <https://trac.webkit.org/changeset/254239>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.