Bug 205951 – Suppress "unused parameter" when including libWebRTC headers in LibWebRTCProviderCocoa.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Wenson Hsieh]

Some unrelated changes to unified source ordering will cause this to become a build error in the future.

[Wenson Hsieh]

Created attachment 387129 [details]
Patch

[Wenson Hsieh]

Comment on attachment 387129 [details]
Patch

Thanks for the review!

[WebKit Commit Bot]

Comment on attachment 387129 [details]
Patch

Clearing flags on attachment: 387129

Committed r254226: <https://trac.webkit.org/changeset/254226>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Why can’t we fix this in WebRTC and upstream the fix, instead?

[youenn fablet]

(In reply to Darin Adler from comment #5)
> Why can’t we fix this in WebRTC and upstream the fix, instead?

We could try but I am not sure what the best way is.

One typical example is: virtual void OnDroppedFrame(DropReason reason) {}.

We could remove the parameter name but I am not sure this will align well with libwebrtc coding style. And adding an UNUSED_PARAM does not seem great.

We could also decide to only include the webrtc headers that we control (the ones in Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit) and move the ALLOW_UNUSED_PARAMETERS_XXX in those headers.

[Darin Adler]

(In reply to youenn fablet from comment #6)
> One typical example is: virtual void OnDroppedFrame(DropReason reason) {}.
> 
> We could remove the parameter name but I am not sure this will align well
> with libwebrtc coding style.

I don’t know what libwebrtc coding style is, but I would propose this:

    virtual void OnDroppedFrame(DropReason /* reason */) {}

(In reply to youenn fablet from comment #6)
> We could also decide to only include the webrtc headers that we control (the
> ones in Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit) and move the
> ALLOW_UNUSED_PARAMETERS_XXX in those headers.

Yes, I think that would be a little better than distributing this responsibility across WebKit code.