Bug 205927 - few web-platform-tests are failing on iOS
Summary: few web-platform-tests are failing on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pablo Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-08 07:43 PST by Aakash Jain
Modified: 2020-01-08 22:53 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-01-08 07:43:33 PST
Following web-platform-tests are failing consistently on iOS:

imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-from-serviceworker.https.html
imported/w3c/web-platform-tests/content-security-policy/frame-src/frame-src-same-document-meta.html
imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub.html
imported/w3c/web-platform-tests/xhr/event-timeout-order.any.html


Seems like it was caused by https://trac.webkit.org/changeset/254133/webkit
Comment 1 Ryan Haddad 2020-01-08 09:51:50 PST
The diffs for the CSP tests suggest that they may just need iOS baselines:

--- /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-from-serviceworker.https-expected.txt
+++ /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-from-serviceworker.https-actual.txt
@@ -1,5 +1,4 @@
 
-Harness Error (FAIL), message = TypeError: undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
 
-NOTRUN A 'frame-ancestors' CSP directive set from a serviceworker response with a value 'none' should block rendering. 
+PASS A 'frame-ancestors' CSP directive set from a serviceworker response with a value 'none' should block rendering. 
 

--- /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/frame-src/frame-src-same-document-meta-expected.txt
+++ /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/frame-src/frame-src-same-document-meta-actual.txt
@@ -1,4 +1,4 @@
-Blocked access to external URL http://www1.%7B%7Bhost%7D%7D/content-security-policy/support/frame.html#0
+Blocked access to external URL http://www1.{{host}}/content-security-policy/support/frame.html#0
 
 
 Harness Error (TIMEOUT), message = null


--- /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub-expected.txt
+++ /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub-actual.txt
@@ -1,4 +1,6 @@
 
 
 PASS Image should load 
+PASS checkReport tests loaded 
+PASS Violation report status OK.
Comment 2 Ryan Haddad 2020-01-08 09:52:19 PST
The XHR one came from https://trac.webkit.org/changeset/254154/webkit

Also looks like it needs an iOS baseline:
--- /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/xhr/event-timeout-order.any-expected.txt
+++ /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/xhr/event-timeout-order.any-actual.txt
@@ -1,3 +1,3 @@
 
-FAIL XMLHttpRequest: event - timeout (order of events) assert_equals: expected "readystatechange(4)" but got "upload.progress(12,12,true)"
+PASS XMLHttpRequest: event - timeout (order of events)
Comment 3 Ryan Haddad 2020-01-08 15:45:28 PST
Added iOS baselines in http://trac.webkit.org/r254231
Comment 4 Radar WebKit Bug Importer 2020-01-08 15:46:12 PST
<rdar://problem/58424725>
Comment 5 Pablo Saavedra 2020-01-08 22:53:32 PST
Thanks Ryan Haddad to take care about the missing baselines for ios-wk2.