Bug 205906 – AI rule for ValueMod/ValueDiv produce constants with the wrong format when the result can be an int32

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

<rdar://problem/56108519>

[Saam Barati]

Created attachment 387069 [details]
patch

[Yusuke Suzuki]

Comment on attachment 387069 [details]
patch

r=me

[WebKit Commit Bot]

Comment on attachment 387069 [details]
patch

Clearing flags on attachment: 387069

Committed r254188: <https://trac.webkit.org/changeset/254188>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Caio Lima]

Comment on attachment 387069 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387069&action=review

> JSTests/stress/ai-value-mod-should-result-in-constant-int-where-possible.js:14
> +                const c = z / 1.0 + 0;

I think you meant "%" here.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:330
> +                    setConstant(node, jsDoubleNumber(left.asNumber() / right.asNumber()));

How does this issue not affect `ArithDiv/ArithMod` as well? IIUC, we can have the same scenario for ArithDiv/ArithMod.

[Saam Barati]

Comment on attachment 387069 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387069&action=review

>> JSTests/stress/ai-value-mod-should-result-in-constant-int-where-possible.js:14
>> +                const c = z / 1.0 + 0;
> 
> I think you meant "%" here.

yes. will fix.

[Saam Barati]

Comment on attachment 387069 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387069&action=review

>> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:330
>> +                    setConstant(node, jsDoubleNumber(left.asNumber() / right.asNumber()));
> 
> How does this issue not affect `ArithDiv/ArithMod` as well? IIUC, we can have the same scenario for ArithDiv/ArithMod.

No, it's not the same. If you read the code for ArithDiv/ArithMod over Double binary use kind, they both return the value in double format.

[Saam Barati]

Comment on attachment 387069 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387069&action=review

>>> JSTests/stress/ai-value-mod-should-result-in-constant-int-where-possible.js:14
>>> +                const c = z / 1.0 + 0;
>> 
>> I think you meant "%" here.
> 
> yes. will fix.

thanks for calling this out.

Fixed in:
https://trac.webkit.org/changeset/254247/webkit