Bug 205901 – Fix specification violation in Font Loading API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Supplying CSS global keywords to the Font Loading API can cause crashes

[Myles C. Maxfield]

Created attachment 387062 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/58083743>

[Brent Fulgham]

Comment on attachment 387062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387062&action=review

> Source/WebCore/ChangeLog:3
> +        Supplying CSS global keywords to the Font Loading API can cause crashes

Suggest changing the title to something like:

"Fix specification violation in Font Loading API"

> Source/WebCore/ChangeLog:9
> +        Simply add a check. The spec says:

Then say: "Our Font Loading API does not comply with the spec: <<< spec language >>>"

"Rather than crashing, we should return a syntax error."

> LayoutTests/fast/text/font-loading-global-keyword-expected.txt:1
> +This test passes if there is no crash.

I don't think this is true. The test passes if we get the expected syntax errors. No need to say something about a crash (all of our tests are expected to pass without crashing!)

> LayoutTests/fast/text/font-loading-global-keyword.html:8
> +description("This test passes if there is no crash.");

description("This test ensure that global CSS keywords generate expected syntax errors.");

[Myles C. Maxfield]

Created attachment 387128 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 387128 [details]
Patch for committing

Clearing flags on attachment: 387128

Committed r254220: <https://trac.webkit.org/changeset/254220>