Bug 205893 - REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
Summary: REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-07 15:42 PST by Truitt Savell
Modified: 2020-01-30 14:39 PST (History)
10 users (show)

See Also:


Attachments
Patch (1.93 KB, patch)
2020-01-09 00:35 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (1.99 KB, patch)
2020-01-09 08:04 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2020-01-07 15:42:05 PST
webrtc/video-autoplay.html

Description:
This test is a flaky failure on Mac. It looks like this may have begun with the changes in https://trac.webkit.org/changeset/253825/webkit

History:
https://results.webkit.org/?suite=layout-tests&test=webrtc%2Fvideo-autoplay.html

Diff:

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/webrtc/video-autoplay-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/webrtc/video-autoplay-actual.txt
@@ -6,7 +6,7 @@
 PASS Local media stream autoplay 
 PASS Remote media stream autoplay 
 PASS Granting getUserMedia should not start paused media 1 
-PASS Granting getUserMedia should not start paused media 2 
+FAIL Granting getUserMedia should not start paused media 2 assert_true: out of DOM video expected true got false
 PASS Granting getUserMedia should not start paused media 3 
 PASS Granting getUserMedia should not start paused media or media that cannot autoplay due to autoplay restrictions
Comment 1 Radar WebKit Bug Importer 2020-01-07 15:42:24 PST
<rdar://problem/58391046>
Comment 2 youenn fablet 2020-01-09 00:23:59 PST
Unable to repro locally.
One possibility is that the removal of the video from the DOM is triggering pausing asynchronously, or is not always updating paused.
I'll update the test to wait for video2 to be paused before calling getUserMedia.
Comment 3 youenn fablet 2020-01-09 00:35:08 PST
Created attachment 387198 [details]
Patch
Comment 4 Eric Carlson 2020-01-09 07:22:30 PST
Comment on attachment 387198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387198&action=review

> LayoutTests/ChangeLog:11
> +        Hypothesis is that removing from DOM the video element is supposed to pause asynchronously the video element.

s/removing from DOM the video element is supposed to pause asynchronously/removing the video element from the DOM is supposed to asynchronously pause/
Comment 5 youenn fablet 2020-01-09 08:04:32 PST
Created attachment 387230 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2020-01-09 08:23:01 PST
Comment on attachment 387230 [details]
Patch for landing

Clearing flags on attachment: 387230

Committed r254260: <https://trac.webkit.org/changeset/254260>
Comment 7 WebKit Commit Bot 2020-01-09 08:23:02 PST
All reviewed patches have been landed.  Closing bug.