Bug 205893 – REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Truitt Savell]

webrtc/video-autoplay.html

Description:
This test is a flaky failure on Mac. It looks like this may have begun with the changes in https://trac.webkit.org/changeset/253825/webkit

History:
https://results.webkit.org/?suite=layout-tests&test=webrtc%2Fvideo-autoplay.html

Diff:

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/webrtc/video-autoplay-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/webrtc/video-autoplay-actual.txt
@@ -6,7 +6,7 @@
 PASS Local media stream autoplay 
 PASS Remote media stream autoplay 
 PASS Granting getUserMedia should not start paused media 1 
-PASS Granting getUserMedia should not start paused media 2 
+FAIL Granting getUserMedia should not start paused media 2 assert_true: out of DOM video expected true got false
 PASS Granting getUserMedia should not start paused media 3 
 PASS Granting getUserMedia should not start paused media or media that cannot autoplay due to autoplay restrictions

[Radar WebKit Bug Importer]

<rdar://problem/58391046>

[youenn fablet]

Unable to repro locally.
One possibility is that the removal of the video from the DOM is triggering pausing asynchronously, or is not always updating paused.
I'll update the test to wait for video2 to be paused before calling getUserMedia.

[youenn fablet]

Created attachment 387198 [details]
Patch

[Eric Carlson]

Comment on attachment 387198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387198&action=review

> LayoutTests/ChangeLog:11
> +        Hypothesis is that removing from DOM the video element is supposed to pause asynchronously the video element.

s/removing from DOM the video element is supposed to pause asynchronously/removing the video element from the DOM is supposed to asynchronously pause/

[youenn fablet]

Created attachment 387230 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 387230 [details]
Patch for landing

Clearing flags on attachment: 387230

Committed r254260: <https://trac.webkit.org/changeset/254260>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.