Bug 205887 - Introduce _WKResourceLoadDelegate
Summary: Introduce _WKResourceLoadDelegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-07 14:29 PST by Alex Christensen
Modified: 2020-02-14 14:37 PST (History)
3 users (show)

See Also:

Attachments
Patch (46.50 KB, patch)
2020-01-07 14:45 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (46.56 KB, patch)
2020-01-07 14:55 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (46.52 KB, patch)
2020-01-07 15:41 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch fixing perf bug (3.31 KB, patch)
2020-02-14 14:11 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-01-07 14:29:33 PST 
Introduce _WKResourceLoadDelegate
Comment 1 Alex Christensen 2020-01-07 14:45:24 PST 
Created attachment 387037 [details]
Patch
Comment 2 Alex Christensen 2020-01-07 14:55:35 PST 
Created attachment 387040 [details]
Patch
Comment 3 Dean Jackson 2020-01-07 15:19:04 PST 
Comment on attachment 387040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387040&action=review

> Source/WebKit/ChangeLog:11
> +        This client will need to be expanded to implement <rdar://problem/57132290> but this is a minimal testable start.

Why mention a radar in a public commit? You should explain what it is.
Comment 4 Alex Christensen 2020-01-07 15:40:42 PST 
Comment on attachment 387040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387040&action=review

>> Source/WebKit/ChangeLog:11
>> +        This client will need to be expanded to implement <rdar://problem/57132290> but this is a minimal testable start.
> 
> Why mention a radar in a public commit? You should explain what it is.

Same reason why any radars are mentioned in WebKit.
This is in case anyone with access to that radar wonders why this is being done.  People without access to that radar can ignore this.  The contents of that radar should not be discussed in a public repository.
Comment 5 Alex Christensen 2020-01-07 15:41:23 PST 
Created attachment 387046 [details]
Patch
Comment 6 Alex Christensen 2020-01-09 14:48:01 PST 
https://trac.webkit.org/changeset/254183/webkit
Comment 7 Radar WebKit Bug Importer 2020-01-09 14:48:13 PST 
<rdar://problem/58458544>
Comment 8 Alex Christensen 2020-02-14 14:11:55 PST 
Created attachment 390815 [details]
patch fixing perf bug
Comment 9 Alex Christensen 2020-02-14 14:37:56 PST 
http://trac.webkit.org/r256646