Bug 205880 - [JSC] Remove vm accessor in JSVirtualMachine to reduce binary size
Summary: [JSC] Remove vm accessor in JSVirtualMachine to reduce binary size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 205877
Blocks:
  Show dependency tree / graph
 
Reported: 2020-01-07 12:14 PST by Yusuke Suzuki
Modified: 2020-01-07 13:14 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.46 KB, patch)
2020-01-07 12:30 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-01-07 12:14:43 PST 
...
Comment 1 Yusuke Suzuki 2020-01-07 12:22:59 PST 
Let's do it right now since it is the largest.
Comment 2 Yusuke Suzuki 2020-01-07 12:30:58 PST 
Created attachment 387019 [details]
Patch
Comment 3 Yusuke Suzuki 2020-01-07 12:32:30 PST 
Comment on attachment 387019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387019&action=review

> Source/JavaScriptCore/API/JSVirtualMachine.mm:301
> +- (JSContextGroupRef)JSContextGroupRef

This style is following `JSContext JSContextRef` accessor.
Comment 4 Mark Lam 2020-01-07 12:35:28 PST 
Comment on attachment 387019 [details]
Patch

Nice.  r=me if bots are green.  Please also run testapi locally to make sure there are no bad surprises (not expecting any).
Comment 5 Yusuke Suzuki 2020-01-07 13:10:47 PST 
(In reply to Mark Lam from comment #4)
> Comment on attachment 387019 [details]
> Patch
> 
> Nice.  r=me if bots are green.  Please also run testapi locally to make sure
> there are no bad surprises (not expecting any).

OK, ensured locally.
Comment 6 Yusuke Suzuki 2020-01-07 13:13:29 PST 
Committed r254152: <https://trac.webkit.org/changeset/254152>
Comment 7 Radar WebKit Bug Importer 2020-01-07 13:14:19 PST 
<rdar://problem/58385111>