Bug 205872 – [CSS Backgrounds] Import WPT css-backgrounds tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

Import WPT css/css-backgrounds

[Carlos Alberto Lopez Perez]

Created attachment 387012 [details]
Patch

Test EWS

[Carlos Alberto Lopez Perez]

Created attachment 388314 [details]
Patch

test EWS

[Carlos Alberto Lopez Perez]

Created attachment 388643 [details]
Patch

test EWS

[Carlos Alberto Lopez Perez]

Created attachment 388702 [details]
Patch

[Simon Fraser (smfr)]

I think last time I tried this, I wanted to fix https://bugs.webkit.org/show_bug.cgi?id=204469 first.

[Simon Fraser (smfr)]

(In reply to Simon Fraser (smfr) from comment #5)
> I think last time I tried this, I wanted to fix
> https://bugs.webkit.org/show_bug.cgi?id=204469 first.

Specifically, I think I saw problems where a ref test had a relative URL to another resource, and copying it to -expected.html broke those relative links.

[Carlos Alberto Lopez Perez]

(In reply to Simon Fraser (smfr) from comment #6)
> (In reply to Simon Fraser (smfr) from comment #5)
> > I think last time I tried this, I wanted to fix
> > https://bugs.webkit.org/show_bug.cgi?id=204469 first.
> 
> Specifically, I think I saw problems where a ref test had a relative URL to
> another resource, and copying it to -expected.html broke those relative
> links.

was this maybe bug 203789 ? I commented there

I have checked this more carefully and the test importer does rewrites of the resources pointed by the ref-tests so relative path URLs should continue to work (in theory), but in practice I already found a few cases where it didn't did what it should. I will try to fix this corner cases I found now on the test-importer-rewriter, but ideally we should fix bug 203784 and stop doing rewrites.

[Carlos Alberto Lopez Perez]

Created attachment 388909 [details]
Patch

Updated patch after re-importing with fix from bug 206842 . Diff: http://sprunge.us/u8qed4?diff

[WebKit Commit Bot]

Comment on attachment 388909 [details]
Patch

Rejecting attachment 388909 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 388909, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:

patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-width-invalid-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-width-invalid.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-width-shorthand-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-width-shorthand.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-width-valid-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-width-valid.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/box-shadow-computed-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/box-shadow-computed.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/box-shadow-invalid-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/box-shadow-invalid.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/box-shadow-valid-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/box-shadow-valid.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/w3c-import.log
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/resources/w3c-import.log
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/scroll-positioned-multiple-background-images-expected.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/scroll-positioned-multiple-background-images.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/support/a-green.css
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/support/b-green.css
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/support/c-red.css
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/support/import-green.css
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/support/import-red.css
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/support/w3c-import.log
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/table-cell-background-local-expected.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/table-cell-background-local.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-css3background-border-color-shorthand-missing-bottom.htm
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-css3background-border-color-shorthand-missing-left.htm
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-css3background-border-color-shorthand-missing-right.htm
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-css3background-border-color-shorthand.htm
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-css3background-border-color.htm
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-css3background-border-style-double.htm
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-css3background-border-style-shorthand-missing-bottom.htm
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-css3background-border-style-shorthand-missing-left.htm
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-css3background-border-style-shorthand.htm
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-css3background-border-style-values.htm
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-css3background-border-style.htm
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-reftest-borderRadius-expected.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/ttwf-reftest-borderRadius.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/w3c-import.log
patching file LayoutTests/platform/gtk/TestExpectations
patching file LayoutTests/platform/ios/TestExpectations
Hunk #1 FAILED at 3463.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/ios/TestExpectations.rej
patching file LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-backgrounds/animations/border-width-interpolation-expected.txt
patching file LayoutTests/platform/wpe/TestExpectations

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13312690

[Carlos Alberto Lopez Perez]

Created attachment 388990 [details]
Patch

Rebased patch for landing

[WebKit Commit Bot]

Comment on attachment 388990 [details]
Patch

Clearing flags on attachment: 388990

Committed r255239: <https://trac.webkit.org/changeset/255239>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58956663>

[Truitt Savell]

This seems to have introduced several flaky crashes:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-backgrounds%2Fbackground-size%2Fvector%2Ftall--auto-32px--nonpercent-width-omitted-height-viewbox.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-backgrounds%2Fbackground-size%2Fvector%2Ftall--auto-32px--nonpercent-width-omitted-height.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-backgrounds%2Fbackground-size%2Fvector%2Ftall--auto-32px--nonpercent-width-percent-height-viewbox.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-backgrounds%2Fbackground-size%2Fvector%2Ftall--auto-32px--nonpercent-width-percent-height.html

imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--auto-32px--nonpercent-width-omitted-height-viewbox.html
imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--auto-32px--nonpercent-width-percent-height.html
imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--auto-32px--nonpercent-width-percent-height-viewbox.html
imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--auto-32px--nonpercent-width-omitted-height.html

[Truitt Savell]

Results page:
https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/r255241%20(1971)/results.html

[Carlos Alberto Lopez Perez]

(In reply to Truitt Savell from comment #15)
> Results page:
> https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/
> r255241%20(1971)/results.html

I see.

Those are expected failures, but on Debug its crashing.

I will try to land a gardening patch updating those

[Carlos Alberto Lopez Perez]

(In reply to Carlos Alberto Lopez Perez from comment #16)
> (In reply to Truitt Savell from comment #15)
> > Results page:
> > https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/
> > r255241%20(1971)/results.html
> 
> I see.
> 
> Those are expected failures, but on Debug its crashing.
> 
> I will try to land a gardening patch updating those

Done in https://trac.webkit.org/changeset/255265

assigned bug 206897

[Truitt Savell]

I followed up with more specific expectations. due to duplication in LayoutTests/expectations these expectations would not be respected properly. 

https://trac.webkit.org/changeset/255274/webkit