Bug 205871 - Bytecode checkpoint fixes for arm64(e)
Summary: Bytecode checkpoint fixes for arm64(e)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-07 10:53 PST by Keith Miller
Modified: 2020-01-07 11:59 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.01 KB, patch)
2020-01-07 10:57 PST, Keith Miller 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-01-07 10:53:00 PST 
Bytecode checkpoint fixes for arm64(e)
Comment 1 Keith Miller 2020-01-07 10:57:34 PST 
Created attachment 386998 [details]
Patch
Comment 2 Michael Saboff 2020-01-07 11:01:16 PST 
Comment on attachment 386998 [details]
Patch

r=me
Comment 3 Keith Miller 2020-01-07 11:02:15 PST 
rdar://problem/58310178
Comment 4 Saam Barati 2020-01-07 11:03:06 PST 
Comment on attachment 386998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386998&action=review

> Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:150
> +        return LLInt::getCodePtr<NoPtrTag>(checkpoint_osr_exit_from_inlined_call_trampoline).executableAddress();

why not make this function return a typed value instead of void*, and then caller's can unbox as needed?
Comment 5 Saam Barati 2020-01-07 11:03:18 PST 
r=me too
Comment 6 Keith Miller 2020-01-07 11:42:04 PST 
Comment on attachment 386998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386998&action=review

>> Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:150
>> +        return LLInt::getCodePtr<NoPtrTag>(checkpoint_osr_exit_from_inlined_call_trampoline).executableAddress();
> 
> why not make this function return a typed value instead of void*, and then caller's can unbox as needed?

Done, I went with MacroAssemblerCodePtr<JSEntryPtrTag> as the type.
Comment 7 Keith Miller 2020-01-07 11:44:06 PST 
Committed r254142: <https://trac.webkit.org/changeset/254142>
Comment 8 Keith Miller 2020-01-07 11:59:30 PST 
Non-arm64e build fix in: https://trac.webkit.org/changeset/254143.