Bug 205849 - Improve logging of creating a service worker
Summary: Improve logging of creating a service worker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-07 01:16 PST by youenn fablet
Modified: 2020-01-08 02:30 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2020-01-07 01:17 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (2.55 KB, patch)
2020-01-08 01:42 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-01-07 01:16:16 PST 
Improve logging of creating a service worker
Comment 1 youenn fablet 2020-01-07 01:17:41 PST 
Created attachment 386949 [details]
Patch
Comment 2 Chris Dumez 2020-01-07 07:53:24 PST 
Comment on attachment 386949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386949&action=review

> Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:158
> +    RELEASE_LOG(ServiceWorker, "Created service worker %s in process PID %i", data.serviceWorkerIdentifier.loggingString().utf8().data(), getCurrentProcessID());

%s -> %{public}s

Note that personally I prefer using data.serviceWorkerIdentifier.toUInt64() rather than constructing a string. I would actually recommend that instead.
Comment 3 youenn fablet 2020-01-08 01:42:06 PST 
Created attachment 387086 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2020-01-08 02:29:48 PST 
Comment on attachment 387086 [details]
Patch for landing

Clearing flags on attachment: 387086

Committed r254191: <https://trac.webkit.org/changeset/254191>
Comment 5 WebKit Commit Bot 2020-01-08 02:29:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-01-08 02:30:14 PST 
<rdar://problem/58403666>