Bug 205838 - Rename start/endPosition to start/endOffset in SelectionRangeData for clarity
Summary: Rename start/endPosition to start/endOffset in SelectionRangeData for clarity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-06 15:38 PST by Megan Gardner
Modified: 2020-01-13 20:14 PST (History)
12 users (show)

See Also:


Attachments
Patch (15.16 KB, patch)
2020-01-06 15:46 PST, Megan Gardner
simon.fraser: review+
Details | Formatted Diff | Diff
Patch (16.20 KB, patch)
2020-01-06 17:41 PST, Megan Gardner
wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch (17.34 KB, patch)
2020-01-07 11:23 PST, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-01-06 15:38:56 PST
Rename start/endPosition to start/endOffset in SelectionRangeData for clarity
Comment 1 Megan Gardner 2020-01-06 15:46:12 PST
Created attachment 386903 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-01-06 15:47:07 PST
Comment on attachment 386903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386903&action=review

> Source/WebCore/ChangeLog:8
> +        Offset is a more correct term for this variable, as it it just an unsigned.

it it
Comment 3 Megan Gardner 2020-01-06 17:41:32 PST
Created attachment 386920 [details]
Patch
Comment 4 Wenson Hsieh 2020-01-06 19:39:44 PST
Comment on attachment 386920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386920&action=review

> Source/WebCore/rendering/InlineTextBox.cpp:187
> +        auto startPos = selection.startOffset();
> +        auto endPos = selection.endOffset();

Let's rename these as well.
Comment 5 Megan Gardner 2020-01-07 11:23:03 PST
Created attachment 387003 [details]
Patch
Comment 6 Radar WebKit Bug Importer 2020-01-07 13:56:47 PST
<rdar://problem/58386840>
Comment 7 WebKit Commit Bot 2020-01-07 14:33:42 PST
Comment on attachment 387003 [details]
Patch

Clearing flags on attachment: 387003

Committed r254159: <https://trac.webkit.org/changeset/254159>