Bug 205835 - [iOS] Get display level in the UI process for all iOS platforms
Summary: [iOS] Get display level in the UI process for all iOS platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-06 14:40 PST by Per Arne Vollan
Modified: 2020-01-10 14:43 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.20 KB, patch)
2020-01-06 14:50 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (6.25 KB, patch)
2020-01-06 15:32 PST, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch (6.24 KB, patch)
2020-01-06 15:41 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-01-06 14:40:45 PST 
This was previously only done for iOS, but should be done for all iOS platforms.
Comment 1 Per Arne Vollan 2020-01-06 14:41:08 PST 
rdar://problem/58116883
Comment 2 Per Arne Vollan 2020-01-06 14:50:53 PST 
Created attachment 386894 [details]
Patch
Comment 3 Brent Fulgham 2020-01-06 15:19:35 PST 
Comment on attachment 386894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386894&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:551
> +#elif PLATFORM(IOS)

I'm not sure this is right. Should this just be "#if PLATFORM(IOS)" and add an #endif? Since the CFNotificationCenterAddObserver is needed by both, but apparently the NSNotification part is only needed for iOS?
Comment 4 Per Arne Vollan 2020-01-06 15:25:59 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 386894 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386894&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:551
> > +#elif PLATFORM(IOS)
> 
> I'm not sure this is right. Should this just be "#if PLATFORM(IOS)" and add
> an #endif? Since the CFNotificationCenterAddObserver is needed by both, but
> apparently the NSNotification part is only needed for iOS?

Ah, you are right. Thanks!
Comment 5 Per Arne Vollan 2020-01-06 15:32:08 PST 
Created attachment 386897 [details]
Patch
Comment 6 Brent Fulgham 2020-01-06 15:33:07 PST 
Comment on attachment 386897 [details]
Patch

Thank you for fixing that! r=me
Comment 7 Per Arne Vollan 2020-01-06 15:41:19 PST 
Created attachment 386902 [details]
Patch
Comment 8 Per Arne Vollan 2020-01-06 15:42:02 PST 
(In reply to Brent Fulgham from comment #6)
> Comment on attachment 386897 [details]
> Patch
> 
> Thank you for fixing that! r=me

Thanks for reviewing :)
Comment 9 WebKit Commit Bot 2020-01-06 17:06:42 PST 
Comment on attachment 386902 [details]
Patch

Clearing flags on attachment: 386902

Committed r254101: <https://trac.webkit.org/changeset/254101>