RESOLVED FIXED 205822
[iOS] Only prewarm fonts with valid font names 
https://bugs.webkit.org/show_bug.cgi?id=205822
Summary [iOS] Only prewarm fonts with valid font names
Per Arne Vollan
Reported 2020-01-06 11:40:53 PST
The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS.
Attachments
Patch (1.35 KB, patch)
2020-01-06 11:43 PST, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (1.37 KB, patch)
2020-01-06 12:49 PST, Per Arne Vollan 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (1.37 KB, patch)
2020-01-06 14:45 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-01-06 11:43:13 PST
Created attachment 386872 [details] Patch
Brent Fulgham
Comment 2 2020-01-06 12:13:01 PST
Comment on attachment 386872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386872&action=review r=me, but I wonder if that conditional should also allow MacCatalyst. > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1697 > +#if PLATFORM(MAC) What about MacCatalyst?
Per Arne Vollan
Comment 3 2020-01-06 12:49:33 PST
Created attachment 386878 [details] Patch
Per Arne Vollan
Comment 4 2020-01-06 12:50:18 PST
(In reply to Brent Fulgham from comment #2) > Comment on attachment 386872 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386872&action=review > > r=me, but I wonder if that conditional should also allow MacCatalyst. > > > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1697 > > +#if PLATFORM(MAC) > > What about MacCatalyst? Fixed. Thanks for reviewing!
WebKit Commit Bot
Comment 5 2020-01-06 14:00:45 PST
Comment on attachment 386878 [details] Patch Rejecting attachment 386878 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 386878, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13300244
Per Arne Vollan
Comment 6 2020-01-06 14:45:49 PST
Created attachment 386890 [details] Patch
WebKit Commit Bot
Comment 7 2020-01-06 16:49:39 PST
Comment on attachment 386890 [details] Patch Clearing flags on attachment: 386890 Committed r254099: <https://trac.webkit.org/changeset/254099>
Radar WebKit Bug Importer
Comment 8 2020-01-06 20:10:39 PST
<rdar://problem/58362968>
Note You need to log in before you can comment on or make changes to this bug.