Bug 205821 – Test history links on the dashboard should go to the new results database

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryan Haddad]

Test history links on the dashboard should go to the new results database (results.webkit.org). They currently point to the old one (webkit-test-results.webkit.org).

Steps to reproduce:
1. Open https://build.webkit.org/dashboard/
2. Hover over a bubble with layout test failures
3. Click the history link next to a test name
4. Observe that the results are displayed on webkit-test-results.webkit.org instead of the new results.webkit.org

[Radar WebKit Bug Importer]

<rdar://problem/58348821>

[Matt Lewis]

Created attachment 388341 [details]
Patch

[Matt Lewis]

There are a bunch of unittest failures but they are from existing failures, I'm working on a patch to help fix those in a separate bug: https://bugs.webkit.org/show_bug.cgi?id=206548

[Aakash Jain]

Comment on attachment 388341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388341&action=review

Can you provide an example of before and after url for test failure?

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:50
> +    return 'https://results.webkit.org/?suite=layout-tests&test=' + encodeURIComponent(testsParameter);

Do we need the '/' in 'results.webkit.org/'?

[Matt Lewis]

so this is a sample url for results.webkit 

https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fappcache%2Fabort-cache-onprogress.html

It used to be this
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=

given that, I assumed it does.

[Jonathan Bedard]

Comment on attachment 388341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388341&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:50
>> +    return 'https://results.webkit.org/?suite=layout-tests&test=' + encodeURIComponent(testsParameter);
> 
> Do we need the '/' in 'results.webkit.org/'?

It it pedantically correct, but we don't need it.

[Matt Lewis]

Committed r254925: <https://trac.webkit.org/changeset/254925>