Bug 205808 - REGRESSION: [ Mac WK2 ] fast/text/international/unicode-bidi-other-neutrals.html is a flaky failure
Summary: REGRESSION: [ Mac WK2 ] fast/text/international/unicode-bidi-other-neutrals.h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-06 10:03 PST by Truitt Savell
Modified: 2020-01-16 13:32 PST (History)
8 users (show)

See Also:


Attachments
Patch (3.17 KB, patch)
2020-01-08 10:12 PST, Doug Kelly
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2020-01-06 10:03:03 PST
fast/text/international/unicode-bidi-other-neutrals.html

Description:
This test is a flaky image failure on Mac wk2. the image appears to have a random 'b' being placed off to the side. this was added in https://trac.webkit.org/changeset/253068/webkit and appears to have been flaky sense then.

History:
https://results.webkit.org/?limit=10000&suite=layout-tests&test=fast%2Ftext%2Finternational%2Funicode-bidi-other-neutrals.html

Diff:
https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/r254052%20(1496)/fast/text/international/unicode-bidi-other-neutrals-diffs.html
Comment 1 Radar WebKit Bug Importer 2020-01-06 10:03:21 PST
<rdar://problem/58345056>
Comment 2 Truitt Savell 2020-01-06 10:08:49 PST
marked this test as failing while it is investigated: https://trac.webkit.org/changeset/254060/webkit
Comment 3 Doug Kelly 2020-01-06 10:23:03 PST
I wonder if this is because of the test's use of the marquee tag -- I wonder if div will reproduce the original issue just the same?
Comment 4 Alexey Proskuryakov 2020-01-06 18:50:50 PST
I think that stopping the marquee with scrollamount="0" or a large scrolldelay would be another workaround.
Comment 5 Doug Kelly 2020-01-07 17:48:44 PST
Realistically, there's also no reason this needs to be an image test... Call it my unfamiliarity with the WebKit test infrastructure, but since this test was verifying that a page with other neutrals at the end of a bidi run would not crash/assert, simply using dumpAsText should be sufficient.

Yes, I'll work on a patch. :)
Comment 6 Doug Kelly 2020-01-08 10:12:29 PST
Created attachment 387110 [details]
Patch
Comment 7 Maciej Stachowiak 2020-01-08 13:55:03 PST
Comment on attachment 387110 [details]
Patch

r=me
Comment 8 Jon Lee 2020-01-10 11:55:28 PST
can we check this in?
Comment 9 WebKit Commit Bot 2020-01-16 13:32:04 PST
Comment on attachment 387110 [details]
Patch

Clearing flags on attachment: 387110

Committed r254705: <https://trac.webkit.org/changeset/254705>
Comment 10 WebKit Commit Bot 2020-01-16 13:32:05 PST
All reviewed patches have been landed.  Closing bug.