Bug 205794 - Fix non unified build in FIDO Pin.cpp
Summary: Fix non unified build in FIDO Pin.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-06 04:32 PST by youenn fablet
Modified: 2020-01-06 13:02 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2020-01-06 04:33 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (5.39 KB, patch)
2020-01-06 05:08 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.64 KB, patch)
2020-01-06 11:07 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-01-06 04:32:46 PST 
Fix unified build in FIDO Pin.cpp
Comment 1 youenn fablet 2020-01-06 04:33:49 PST 
Created attachment 386831 [details]
Patch
Comment 2 youenn fablet 2020-01-06 05:08:48 PST 
Created attachment 386832 [details]
Patch
Comment 3 Jiewen Tan 2020-01-06 09:41:21 PST 
Comment on attachment 386832 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386832&action=review

Thanks for catching this bug. My bad.

> Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp:-47
> -constexpr size_t kResponseCodeLength = 1;

I think it is better to name it CtapDeviceResponseCodeLength = 1 in FidoConstants.h after enum class CtapDeviceResponseCode.
Comment 4 youenn fablet 2020-01-06 11:07:24 PST 
Created attachment 386865 [details]
Patch
Comment 5 Jiewen Tan 2020-01-06 11:17:03 PST 
Comment on attachment 386865 [details]
Patch

r=me. Thanks for making the patch.
Comment 6 WebKit Commit Bot 2020-01-06 12:56:48 PST 
Comment on attachment 386865 [details]
Patch

Clearing flags on attachment: 386865

Committed r254079: <https://trac.webkit.org/changeset/254079>
Comment 7 WebKit Commit Bot 2020-01-06 12:56:56 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-01-06 13:02:07 PST 
<rdar://problem/58351406>