NEW 205790
[iOS] Enable SPI to toggle PIP and to query PIP state and availability 
https://bugs.webkit.org/show_bug.cgi?id=205790
Summary [iOS] Enable SPI to toggle PIP and to query PIP state and availability
Luming Yin
Reported 2020-01-06 01:19:15 PST
<rdar://problem/58335197>
Attachments
Patch (9.47 KB, patch)
2020-01-06 03:03 PST, Luming Yin 		no flags
DetailsFormatted DiffDiff
Patch (8.03 KB, patch)
2020-01-06 03:16 PST, Luming Yin 		no flags
DetailsFormatted DiffDiff
Patch (8.07 KB, patch)
2020-01-06 05:46 PST, Luming Yin 		no flags
DetailsFormatted DiffDiff
Patch (7.98 KB, patch)
2020-01-06 08:29 PST, Luming Yin 		no flags
DetailsFormatted DiffDiff
Patch (7.72 KB, patch)
2020-01-06 08:53 PST, Luming Yin 		no flags
DetailsFormatted DiffDiff
Patch (7.73 KB, patch)
2020-01-13 15:27 PST, Luming Yin 		no flags
DetailsFormatted DiffDiff
Patch (7.95 KB, patch)
2020-01-14 13:44 PST, Luming Yin 		no flags
DetailsFormatted DiffDiff
Patch (7.74 KB, patch)
2020-01-14 16:21 PST, Luming Yin 		jer.noble: review+
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Luming Yin
Comment 1 2020-01-06 03:03:06 PST
Created attachment 386824 [details] Patch
Luming Yin
Comment 2 2020-01-06 03:16:37 PST
Created attachment 386826 [details] Patch
Luming Yin
Comment 3 2020-01-06 05:46:24 PST
Created attachment 386837 [details] Patch
Luming Yin
Comment 4 2020-01-06 08:29:49 PST
Created attachment 386847 [details] Patch
Luming Yin
Comment 5 2020-01-06 08:53:47 PST
Created attachment 386850 [details] Patch
Eric Carlson
Comment 6 2020-01-11 13:54:21 PST
Comment on attachment 386850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386850&action=review > Source/WebKit/ChangeLog:10 > + enabled to work on iOS. We also move the iOS implementation of toggling picture-in-picture out out of s/out out/out/
Luming Yin
Comment 7 2020-01-13 15:27:00 PST
Created attachment 387577 [details] Patch
Luming Yin
Comment 8 2020-01-14 13:44:36 PST
Created attachment 387697 [details] Patch
Jer Noble
Comment 9 2020-01-14 16:09:01 PST
Comment on attachment 387697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387697&action=review r=me with nits > Source/WebKit/UIProcess/WebPageProxy.cpp:5991 > + PlatformPlaybackSessionInterface* playbackSessionInterface = sessionManager->controlsManagerInterface(); > + if (!playbackSessionInterface) > + return nullptr; if (auto playbackSessionInterface = sessionManager->controlsManagerInterface()) return playbackSessionInterface->playbackSessionModel(); return nullptr; > Source/WebKit/UIProcess/WebPageProxy.cpp:5999 > + WebCore::PlaybackSessionModel* sessionModel = playbackSessionModel(); > + if (sessionModel) if (auto sessionModel = playbackSessionModel()) > Source/WebKit/UIProcess/WebPageProxy.cpp:6006 > + WebCore::PlaybackSessionModel* sessionModel = playbackSessionModel(); > + if (sessionModel) Ditto. > Source/WebKit/UIProcess/WebPageProxy.cpp:6015 > + PlaybackSessionModel* sessionModel = playbackSessionModel(); > + if (sessionModel) Ditto.
Luming Yin
Comment 10 2020-01-14 16:21:31 PST
Created attachment 387723 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.