Bug 205789 - Add WKWebView SPI to query _WKMediaMutedState
Summary: Add WKWebView SPI to query _WKMediaMutedState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-06 01:17 PST by Luming Yin
Modified: 2020-01-06 12:29 PST (History)
9 users (show)

See Also:

Attachments
Patch (17.25 KB, patch)
2020-01-06 03:12 PST, Luming Yin 		no flags Details | Formatted Diff | Diff
Patch (17.29 KB, patch)
2020-01-06 05:41 PST, Luming Yin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luming Yin 2020-01-06 01:17:02 PST 
<rdar://problem/58335241>
Comment 1 Luming Yin 2020-01-06 03:12:34 PST 
Created attachment 386825 [details]
Patch
Comment 2 Eric Carlson 2020-01-06 05:32:58 PST 
Comment on attachment 386825 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386825&action=review

> Source/WebKit/ChangeLog:5
> +        https://bugs.webkit.org/show_bug.cgi?id=205789
> +

This should have a Radar link as well as but bugzilla link.

> Source/WebKit/UIProcess/Cocoa/MediaUtilities.h:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

Nit: might as well make this "2018-2020"

> Source/WebKit/UIProcess/Cocoa/MediaUtilities.mm:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

Ditto
Comment 3 Luming Yin 2020-01-06 05:41:02 PST 
Created attachment 386835 [details]
Patch
Comment 4 Eric Carlson 2020-01-06 05:51:57 PST 
Comment on attachment 386835 [details]
Patch

r=me once the bots are happy with the patch
Comment 5 WebKit Commit Bot 2020-01-06 12:29:56 PST 
Comment on attachment 386835 [details]
Patch

Clearing flags on attachment: 386835

Committed r254075: <https://trac.webkit.org/changeset/254075>
Comment 6 WebKit Commit Bot 2020-01-06 12:29:58 PST 
All reviewed patches have been landed.  Closing bug.