Bug 205781 - Remove some #ifdefs related to iOS port of ANGLE
Summary: Remove some #ifdefs related to iOS port of ANGLE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords: InRadar
Depends on: 205618
Blocks:
  Show dependency tree / graph
 
Reported: 2020-01-05 14:26 PST by Kenneth Russell
Modified: 2020-01-08 18:46 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.80 KB, patch)
2020-01-08 17:38 PST, Kenneth Russell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2020-01-05 14:26:21 PST 
With the port to the iOS Simulator in bug 205618, a couple of #ifdefs that were added to ANGLE for the iOS port should be able to be removed.

They've been highlighted in this code review upstreaming the iOS port to the ANGLE repository:
https://chromium-review.googlesource.com/1987278

We should try removing them, retest on both iOS hardware and the simulator, and if they're unnecessary, upstream their removal.
Comment 1 Kenneth Russell 2020-01-08 17:38:52 PST 
Created attachment 387172 [details]
Patch
Comment 2 Kenneth Russell 2020-01-08 17:39:53 PST 
Dean: could you please test these changes on iOS hardware? They work in the iOS Simulator. This would help with the upstreaming of the iOS backend. Thanks!
Comment 3 EWS Watchlist 2020-01-08 17:39:59 PST 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 WebKit Commit Bot 2020-01-08 18:45:08 PST 
Comment on attachment 387172 [details]
Patch

Clearing flags on attachment: 387172

Committed r254249: <https://trac.webkit.org/changeset/254249>
Comment 5 WebKit Commit Bot 2020-01-08 18:45:09 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-01-08 18:46:14 PST 
<rdar://problem/58430149>