Bug 205778 - Rename GraphicsContext3D to GraphicsContextGL
Summary: Rename GraphicsContext3D to GraphicsContextGL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-05 12:42 PST by Dean Jackson
Modified: 2020-01-06 21:54 PST (History)
35 users (show)

See Also:


Attachments
Patch (1.66 MB, patch)
2020-01-05 13:41 PST, Dean Jackson
sam: review+
Details | Formatted Diff | Diff
EWS test (1.66 MB, patch)
2020-01-05 20:09 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
EWS test (1.66 MB, patch)
2020-01-06 09:36 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
EWS test (1.66 MB, patch)
2020-01-06 09:53 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
Build fix (14.22 KB, patch)
2020-01-06 16:10 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2020-01-05 12:42:40 PST
Rename GraphicsContext3D to GraphicsContextGL
Comment 1 Dean Jackson 2020-01-05 13:41:07 PST
Created attachment 386797 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-01-05 13:41:28 PST
<rdar://problem/58327597>
Comment 3 Sam Weinig 2020-01-05 15:21:34 PST
Comment on attachment 386797 [details]
Patch

rs=me, but get it building first.
Comment 4 Dean Jackson 2020-01-05 20:09:46 PST
Created attachment 386806 [details]
EWS test
Comment 5 Dean Jackson 2020-01-06 09:36:18 PST
Created attachment 386854 [details]
EWS test
Comment 6 Dean Jackson 2020-01-06 09:53:37 PST
Created attachment 386856 [details]
EWS test
Comment 7 Dean Jackson 2020-01-06 11:15:21 PST
Committed r254064: <https://trac.webkit.org/changeset/254064>
Comment 8 Don Olmstead 2020-01-06 15:59:06 PST
Reopening to land build fix
Comment 9 Don Olmstead 2020-01-06 16:10:12 PST
Created attachment 386908 [details]
Build fix
Comment 10 Don Olmstead 2020-01-06 16:43:42 PST Comment hidden (obsolete)
Comment 11 Don Olmstead 2020-01-06 16:43:48 PST Comment hidden (obsolete)
Comment 12 Don Olmstead 2020-01-06 16:44:13 PST
Comment on attachment 386908 [details]
Build fix

Mac and GTK seem happy. Asking for a review since I modified Platform.h and added USE_ macros.
Comment 13 WebKit Commit Bot 2020-01-06 18:52:34 PST
Comment on attachment 386908 [details]
Build fix

Clearing flags on attachment: 386908

Committed r254103: <https://trac.webkit.org/changeset/254103>
Comment 14 Don Olmstead 2020-01-06 21:54:00 PST
Build is back to green