Bug 205775 - [GTK][WPE] Prepare bots for Flatpak migration
Summary: [GTK][WPE] Prepare bots for Flatpak migration
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks: 205658
  Show dependency tree / graph
 
Reported: 2020-01-05 01:55 PST by Philippe Normand
Modified: 2020-01-10 05:26 PST (History)
3 users (show)

See Also:

Attachments
Patch (10.76 KB, patch)
2020-01-05 02:41 PST, Philippe Normand 		clopez: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-01-05 01:55:55 PST 
Bots should have a WEBKIT_JHBUILD=1 env var set. See bug 205658
Comment 1 Philippe Normand 2020-01-05 02:41:10 PST 
Created attachment 386784 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2020-01-06 09:28:14 PST 
Comment on attachment 386784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386784&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:224
> +def appendCustomEnvironmentVariables(step, platform):
> +    if platform in ('gtk', 'wpe'):
> +        step.slaveEnvironment['WEBKIT_JHBUILD'] = '1'
> +

Please don't add this environment variable from the buildbot master config.
Each worker defines its own environment variables at startup. This is something that the admin of the bot does (on a systemd unit file usually)
Before landing this patch you need to talk with the admins of the GTK/EWS bots to add this environment variable to each of the bots environment.

> Tools/BuildSlaveSupport/ews-build/steps.py:782
> +def appendCustomEnvironmentVariables(step, platform):
> +    if platform in ('gtk', 'wpe'):
> +        step.slaveEnvironment['WEBKIT_JHBUILD'] = '1'
> +

Ditto

> Tools/BuildSlaveSupport/gtk/buildbot/run:71
> +		WEBKIT_JHBUILD=1 \

Ditto
Comment 3 Philippe Normand 2020-01-06 09:30:53 PST 
Aakash, any thoughts about this?