RESOLVED INVALID 205775
[GTK][WPE] Prepare bots for Flatpak migration 
https://bugs.webkit.org/show_bug.cgi?id=205775
Summary [GTK][WPE] Prepare bots for Flatpak migration
Philippe Normand
Reported 2020-01-05 01:55:55 PST
Bots should have a WEBKIT_JHBUILD=1 env var set. See bug 205658
Attachments
Patch (10.76 KB, patch)
2020-01-05 02:41 PST, Philippe Normand 		clopez: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-01-05 02:41:10 PST
Created attachment 386784 [details] Patch
Carlos Alberto Lopez Perez
Comment 2 2020-01-06 09:28:14 PST
Comment on attachment 386784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386784&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:224 > +def appendCustomEnvironmentVariables(step, platform): > + if platform in ('gtk', 'wpe'): > + step.slaveEnvironment['WEBKIT_JHBUILD'] = '1' > + Please don't add this environment variable from the buildbot master config. Each worker defines its own environment variables at startup. This is something that the admin of the bot does (on a systemd unit file usually) Before landing this patch you need to talk with the admins of the GTK/EWS bots to add this environment variable to each of the bots environment. > Tools/BuildSlaveSupport/ews-build/steps.py:782 > +def appendCustomEnvironmentVariables(step, platform): > + if platform in ('gtk', 'wpe'): > + step.slaveEnvironment['WEBKIT_JHBUILD'] = '1' > + Ditto > Tools/BuildSlaveSupport/gtk/buildbot/run:71 > + WEBKIT_JHBUILD=1 \ Ditto
Philippe Normand
Comment 3 2020-01-06 09:30:53 PST
Aakash, any thoughts about this?
Note You need to log in before you can comment on or make changes to this bug.