Bug 205773 - [LFC][Integration] Fix fast/repaint/simple-line-layout-shrinking-content.html
Summary: [LFC][Integration] Fix fast/repaint/simple-line-layout-shrinking-content.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-04 17:41 PST by zalan
Modified: 2020-01-05 07:36 PST (History)
11 users (show)

See Also:

Attachments
Patch (2.14 KB, patch)
2020-01-04 17:59 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-01-04 17:41:26 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2020-01-04 17:41:46 PST 
<rdar://problem/58319960>
Comment 2 zalan 2020-01-04 17:59:56 PST 
Created attachment 386777 [details]
Patch
Comment 3 Antti Koivisto 2020-01-05 00:05:48 PST 
Comment on attachment 386777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386777&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:3724
> +    repaintLogicalTop = contentBoxTop;
> +    repaintLogicalBottom = borderBoxBottom;

Shouldn't both these be from the same box?
Comment 4 WebKit Commit Bot 2020-01-05 06:50:16 PST 
Comment on attachment 386777 [details]
Patch

Clearing flags on attachment: 386777

Committed r254040: <https://trac.webkit.org/changeset/254040>
Comment 5 WebKit Commit Bot 2020-01-05 06:50:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 zalan 2020-01-05 07:36:48 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 386777 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386777&action=review
> 
> > Source/WebCore/rendering/RenderBlockFlow.cpp:3724
> > +    repaintLogicalTop = contentBoxTop;
> > +    repaintLogicalBottom = borderBoxBottom;
> 
> Shouldn't both these be from the same box?
This repaint logic should really just be about the content box. Right now I am just matching SLL behavior.