ECMA262: https://tc39.es/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys (step 11) 1. If Object.getOwnPropertyNames is called on Proxy with "ownKeys" trap, symbol keys of Proxy's target are ignored during invariants validation. Test262: https://test262.report/browse/built-ins/Object/getOwnPropertyNames/proxy-invariant-absent-not-configurable-symbol-key.js https://test262.report/browse/built-ins/Object/getOwnPropertyNames/proxy-invariant-not-extensible-absent-symbol-key.js https://test262.report/browse/built-ins/Object/getOwnPropertyNames/proxy-invariant-not-extensible-extra-symbol-key.js 2. If Object.getOwnPropertySymbols is called on Proxy with "ownKeys" trap, string keys of Proxy's target are ignored during invariants validation. Test262: https://test262.report/browse/built-ins/Object/getOwnPropertySymbols/proxy-invariant-absent-not-configurable-string-key.js https://test262.report/browse/built-ins/Object/getOwnPropertySymbols/proxy-invariant-not-extensible-absent-string-key.js https://test262.report/browse/built-ins/Object/getOwnPropertySymbols/proxy-invariant-not-extensible-extra-string-key.js
Created attachment 386780 [details] Patch
Created attachment 386874 [details] Patch Rebase patch.
Created attachment 387017 [details] Patch Remove `seenKeys` and explanation comment about it.
Comment on attachment 387017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387017&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + (step 11 of https://tc39.es/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys) Seems like it's more than just step 11 though, right?
Created attachment 387104 [details] Patch Set reviewer and tweak ChangeLog.
Comment on attachment 387104 [details] Patch Clearing flags on attachment: 387104 Committed r254205: <https://trac.webkit.org/changeset/254205>
All reviewed patches have been landed. Closing bug.
<rdar://problem/58414163>