Bug 205771 – [LFC][Integration] Fix compositing/masks/compositing-clip-path-change-no-repaint.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

ssia

[Radar WebKit Bug Importer]

<rdar://problem/58319828>

[alan]

Created attachment 386776 [details]
Patch

[Antti Koivisto]

Comment on attachment 386776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386776&action=review

> Source/WebCore/ChangeLog:3
> +        [LFC][IFC] Fix compositing/masks/compositing-clip-path-change-no-repaint.html

[LFC][Integration]

[Antti Koivisto]

Comment on attachment 386776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386776&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:-2090
>      if (diff >= StyleDifference::Repaint) {
> -        // FIXME: This could use a cheaper style-only test instead of SimpleLineLayout::canUseFor.
> -        if (selfNeedsLayout() || !simpleLineLayout() || !SimpleLineLayout::canUseFor(*this))

If we don't redo the layout then we need to push the style change to LFC too.

[alan]

Created attachment 386785 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 386785 [details]
Patch

Clearing flags on attachment: 386785

Committed r254041: <https://trac.webkit.org/changeset/254041>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.