Bug 205771 - [LFC][Integration] Fix compositing/masks/compositing-clip-path-change-no-repaint.html
Summary: [LFC][Integration] Fix compositing/masks/compositing-clip-path-change-no-repa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-04 17:14 PST by zalan
Modified: 2020-01-05 07:13 PST (History)
11 users (show)

See Also:

Attachments
Patch (2.17 KB, patch)
2020-01-04 17:24 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.21 KB, patch)
2020-01-05 06:25 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-01-04 17:14:18 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2020-01-04 17:14:40 PST 
<rdar://problem/58319828>
Comment 2 zalan 2020-01-04 17:24:26 PST 
Created attachment 386776 [details]
Patch
Comment 3 Antti Koivisto 2020-01-05 00:00:12 PST 
Comment on attachment 386776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386776&action=review

> Source/WebCore/ChangeLog:3
> +        [LFC][IFC] Fix compositing/masks/compositing-clip-path-change-no-repaint.html

[LFC][Integration]
Comment 4 Antti Koivisto 2020-01-05 00:07:19 PST 
Comment on attachment 386776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386776&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:-2090
>      if (diff >= StyleDifference::Repaint) {
> -        // FIXME: This could use a cheaper style-only test instead of SimpleLineLayout::canUseFor.
> -        if (selfNeedsLayout() || !simpleLineLayout() || !SimpleLineLayout::canUseFor(*this))

If we don't redo the layout then we need to push the style change to LFC too.
Comment 5 zalan 2020-01-05 06:25:30 PST 
Created attachment 386785 [details]
Patch
Comment 6 WebKit Commit Bot 2020-01-05 07:13:15 PST 
Comment on attachment 386785 [details]
Patch

Clearing flags on attachment: 386785

Committed r254041: <https://trac.webkit.org/changeset/254041>
Comment 7 WebKit Commit Bot 2020-01-05 07:13:16 PST 
All reviewed patches have been landed.  Closing bug.