Bug 205764 - REGRESSION (r248734): different threads write m_storageMap of StorageAreaImpl at the same time
Summary: REGRESSION (r248734): different threads write m_storageMap of StorageAreaImpl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-03 22:19 PST by Sihui Liu
Modified: 2020-01-07 16:17 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2020-01-03 22:27 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-01-03 22:19:43 PST 
<rdar://problem/58179425>
Comment 1 Sihui Liu 2020-01-03 22:27:15 PST 
Created attachment 386755 [details]
Patch
Comment 2 Maciej Stachowiak 2020-01-06 18:49:44 PST 
Comment on attachment 386755 [details]
Patch

r=me

Is it possible to make a test case for this that fails even without ASAN?
Comment 3 Sihui Liu 2020-01-07 15:03:05 PST 
(In reply to Maciej Stachowiak from comment #2)
> Comment on attachment 386755 [details]
> Patch
> 
> r=me
> 
> Is it possible to make a test case for this that fails even without ASAN?

It could be hard to write a dedicated test due to the race condition, and it looks like usually we only change session of WebView between tests (reseting preferences between tests in DumpRenderTree), not in one test.
Comment 4 WebKit Commit Bot 2020-01-07 16:17:41 PST 
Comment on attachment 386755 [details]
Patch

Clearing flags on attachment: 386755

Committed r254169: <https://trac.webkit.org/changeset/254169>
Comment 5 WebKit Commit Bot 2020-01-07 16:17:43 PST 
All reviewed patches have been landed.  Closing bug.