Bug 205761 - DumpRenderTree doesn't always call updateRendering() when a test completes
Summary: DumpRenderTree doesn't always call updateRendering() when a test completes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: 205694
  Show dependency tree / graph
 
Reported: 2020-01-03 18:22 PST by Simon Fraser (smfr)
Modified: 2020-01-13 20:16 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.36 KB, patch)
2020-01-03 18:27 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (8.68 KB, patch)
2020-01-03 18:44 PST, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-01-03 18:22:11 PST 
Fix a souce of WebKit1 test flakiness
Comment 1 Simon Fraser (smfr) 2020-01-03 18:27:28 PST 
Created attachment 386740 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-01-03 18:44:14 PST 
Created attachment 386743 [details]
Patch
Comment 3 Darin Adler 2020-01-03 19:30:55 PST 
Comment on attachment 386743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386743&action=review

> Source/WebKitLegacy/mac/WebView/WebView.mm:4775
> +    // Ensure fixed positions layers are where they should be.

I think there's a grammar error here. I should be "fixed position layers" maybe?
Comment 4 Simon Fraser (smfr) 2020-01-05 09:58:40 PST 
https://trac.webkit.org/changeset/254042/webkit
Comment 5 Radar WebKit Bug Importer 2020-01-05 09:59:23 PST 
<rdar://problem/58325946>
Comment 6 Truitt Savell 2020-01-06 10:41:29 PST 
The changes in https://trac.webkit.org/changeset/254042/webkit has broken 5 pageoverlay/overlay- tests on Mac wk1

Tracking in https://bugs.webkit.org/show_bug.cgi?id=205810
Comment 7 Ryosuke Niwa 2020-01-13 20:16:18 PST 
Nice! Thanks for this fix.