Bug 205753 – The "ITP Database Backend" flag is not working correctly

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKit Misc.

[Kate Cheney]

Since being turned on-by-default, the ITP Database flag has stopped working correctly.

[Radar WebKit Bug Importer]

<rdar://problem/58309011>

[Kate Cheney]

Created attachment 386730 [details]
Patch

[Dean Jackson]

Comment on attachment 386730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386730&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:402
> +    if (!isITPDatabaseEnabledValue)
> +        parameters.shouldEnableITPDatabase = m_defaultPageGroup->preferences().isITPDatabaseEnabled();
> +    else
> +        parameters.shouldEnableITPDatabase = isITPDatabaseEnabledValue.boolValue;

I think this conditional should be reversed. i.e. if the value from user prefs exists, use it, otherwise go to the page group defaults.

[Kate Cheney]

(In reply to Dean Jackson from comment #3)
> Comment on attachment 386730 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386730&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:402
> > +    if (!isITPDatabaseEnabledValue)
> > +        parameters.shouldEnableITPDatabase = m_defaultPageGroup->preferences().isITPDatabaseEnabled();
> > +    else
> > +        parameters.shouldEnableITPDatabase = isITPDatabaseEnabledValue.boolValue;
> 
> I think this conditional should be reversed. i.e. if the value from user
> prefs exists, use it, otherwise go to the page group defaults.

I agree, that order is more readable. I'll change it before landing. 

These api test failures also look concerning, I'll investigate.

[Kate Cheney]

this was fixed (along with the failing api tests) in https://bugs.webkit.org/show_bug.cgi?id=205844

[Kate Cheney]

*** This bug has been marked as a duplicate of bug 205844 ***