Some changes were needed after https://trac.webkit.org/changeset/253939/webkit It seems like NO_ERROR was hitting the windows define. Some code being used on wincairo was accessing m_attrs and needed to change. Some functions were showing up as undefined that were in an #ifdef PLATFORM(GTK) && !USE(ANGLE)
Created attachment 386703 [details] Patch Not sure if all the changes here work for other platforms and a bit uncertain about whether the endif move was the right solution.
Created attachment 386708 [details] Patch Updating to try to fix wpe failure on first patch. Still running build for wincairo locally but want to check wpe's behavior.
Comment on attachment 386708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386708&action=review LGTM. Just making a note that I think we'll want to revisit some of these platform checks since they don't seem correct. > Source/WebCore/platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp:483 > +#if (PLATFORM(GTK) && !USE(ANGLE)) || PLATFORM(WIN) I think we maybe need a bug to audit these PLATFORM checks within the GraphicsContext3D stuff. The function glMapBufferRange is just OpenGL(ES) 3+ so this feels wrong.
Comment on attachment 386708 [details] Patch Clearing flags on attachment: 386708 Committed r254026: <https://trac.webkit.org/changeset/254026>
All reviewed patches have been landed. Closing bug.
<rdar://problem/58311654>
Nice!
*** Bug 205636 has been marked as a duplicate of this bug. ***