Bug 205740 - Update the RemoteMediaPlayerManagerProxy::Load XPC message to provide the updated RemoteMediaPlayerConfiguration to the web process
Summary: Update the RemoteMediaPlayerManagerProxy::Load XPC message to provide the upd...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-03 11:32 PST by Peng Liu
Modified: 2020-01-03 19:10 PST (History)
8 users (show)

See Also:

Attachments
Patch (11.17 KB, patch)
2020-01-03 11:54 PST, Peng Liu 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (10.73 KB, patch)
2020-01-03 12:35 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-01-03 11:32:24 PST 
Update the RemoteMediaPlayerManagerProxy::Load XPC message to provide the updated RemoteMediaPlayerConfiguration to the web process
Comment 1 Radar WebKit Bug Importer 2020-01-03 11:44:50 PST 
<rdar://problem/58303388>
Comment 2 Peng Liu 2020-01-03 11:54:09 PST 
Created attachment 386701 [details]
Patch
Comment 3 Eric Carlson 2020-01-03 12:27:24 PST 
Comment on attachment 386701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386701&action=review

Thanks!

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:94
> +    configuration.engineDescription = m_player->engineDescription();
> +    configuration.supportsScanning = m_player->supportsScanning();
> +    configuration.supportsFullscreen = m_player->supportsFullscreen();
> +    configuration.supportsPictureInPicture = m_player->supportsPictureInPicture();
> +    configuration.supportsAcceleratedRendering = m_player->supportsAcceleratedRendering();
> +    configuration.canPlayToWirelessPlaybackTarget = m_player->canPlayToWirelessPlaybackTarget();

Nit: is there any really you can't use getConfiguration()?
Comment 4 Peng Liu 2020-01-03 12:32:44 PST 
Comment on attachment 386701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386701&action=review

>> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:94
>> +    configuration.canPlayToWirelessPlaybackTarget = m_player->canPlayToWirelessPlaybackTarget();
> 
> Nit: is there any really you can't use getConfiguration()?

No, I should have used getConfiguration() here. Fixed.
Comment 5 Peng Liu 2020-01-03 12:35:17 PST 
Created attachment 386707 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2020-01-03 15:25:44 PST 
Comment on attachment 386707 [details]
Patch for landing

Clearing flags on attachment: 386707

Committed r254019: <https://trac.webkit.org/changeset/254019>