Bug 205740 – Update the RemoteMediaPlayerManagerProxy::Load XPC message to provide the updated RemoteMediaPlayerConfiguration to the web process

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Peng Liu]

Update the RemoteMediaPlayerManagerProxy::Load XPC message to provide the updated RemoteMediaPlayerConfiguration to the web process

[Radar WebKit Bug Importer]

<rdar://problem/58303388>

[Peng Liu]

Created attachment 386701 [details]
Patch

[Eric Carlson]

Comment on attachment 386701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386701&action=review

Thanks!

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:94
> +    configuration.engineDescription = m_player->engineDescription();
> +    configuration.supportsScanning = m_player->supportsScanning();
> +    configuration.supportsFullscreen = m_player->supportsFullscreen();
> +    configuration.supportsPictureInPicture = m_player->supportsPictureInPicture();
> +    configuration.supportsAcceleratedRendering = m_player->supportsAcceleratedRendering();
> +    configuration.canPlayToWirelessPlaybackTarget = m_player->canPlayToWirelessPlaybackTarget();

Nit: is there any really you can't use getConfiguration()?

[Peng Liu]

Comment on attachment 386701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386701&action=review

>> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:94
>> +    configuration.canPlayToWirelessPlaybackTarget = m_player->canPlayToWirelessPlaybackTarget();
> 
> Nit: is there any really you can't use getConfiguration()?

No, I should have used getConfiguration() here. Fixed.

[Peng Liu]

Created attachment 386707 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 386707 [details]
Patch for landing

Clearing flags on attachment: 386707

Committed r254019: <https://trac.webkit.org/changeset/254019>