Bug 205739 - webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html is timing out on some hardware configurations
Summary: webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html is timing o...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
Keywords: InRadar
Depends on:
Blocks: webglangle
  Show dependency treegraph
Reported: 2020-01-03 11:15 PST by Truitt Savell
Modified: 2020-03-11 17:12 PDT (History)
10 users (show)

See Also:

Optimize disabling ANGLE_texture_rectangle (2.04 KB, patch)
2020-02-05 17:49 PST, James Darpinian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2020-01-03 11:15:49 PST

This test began failing after r253926. this may just be a rebase


--- /Volumes/Data/slave/catalina-debug-tests-wk2-webgl/build/layout-test-results/webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk2-webgl/build/layout-test-results/webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words-actual.txt
@@ -1,5 +1,5 @@
-#PID UNRESPONSIVE - WebKitTestRunner (pid 96218)
-FAIL: Timed out waiting for notifyDone to be called
+This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
+Test: ../../../resources/webgl_test_files/conformance/glsl/misc/shader-with-reserved-words.html
+[ PASS ] All tests passed
Comment 1 Radar WebKit Bug Importer 2020-01-03 11:16:06 PST
Comment 2 Alexey Proskuryakov 2020-01-05 19:33:05 PST
This is a tricky one, but there is definitely something wrong going on here, both with and without ANGLE.

This test is skipped in most configurations, and marked as a flaky timeout in the few configurations where it runs. But it also appears to be skipped on internal bots (although I don't understand how), so we don't have results from different hardware configurations.

LayoutTests/TestExpectations:3823:webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html [ Skip ]
LayoutTests/platform/mac-wk1/TestExpectations:583:webkit.org/b/170877 [ Debug ] webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html [ Pass Timeout ]
LayoutTests/platform/mac/TestExpectations:1728:webkit.org/b/170877 [ Debug ] webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html [ Pass Timeout ]

Anyway, this test times out on Mac minis with or without ANGLE. It passes on iMac16,2, also with or without. It presumably timed out in a different way on Dean's iMac Pro (?), making him land this "#PID UNRESPONSIVE" expectation.
Comment 3 Alexey Proskuryakov 2020-01-05 19:34:17 PST
Reusing this but to track all issues with this test.
Comment 4 James Darpinian 2020-01-08 18:34:32 PST
I've identified a regression in shader compilation performance with ANGLE enabled, so I will fix that. After fixing the regression the performance should be the same with and without ANGLE, so if it was timing out before then it will probably still timeout.
Comment 5 James Darpinian 2020-02-05 17:49:36 PST
Created attachment 389921 [details]
Optimize disabling ANGLE_texture_rectangle
Comment 6 WebKit Commit Bot 2020-02-06 15:39:26 PST
Comment on attachment 389921 [details]
Optimize disabling ANGLE_texture_rectangle

Clearing flags on attachment: 389921

Committed r255990: <https://trac.webkit.org/changeset/255990>
Comment 7 WebKit Commit Bot 2020-02-06 15:39:27 PST
All reviewed patches have been landed.  Closing bug.