Bug 205699 – Align XPathEvaluator.createNSResolver() / XPathResult.snapshotItem() with the specification

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Dumez]

Align XPathEvaluator.createNSResolver() / XPathResult.snapshotItem() with the specification and other browsers. In particular, their parameter should not be optional.

[Chris Dumez]

Created attachment 386642 [details]
Patch

[Chris Dumez]

Created attachment 386647 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Commit Bot]

Comment on attachment 386647 [details]
Patch

Rejecting attachment 386647 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 386647, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=386647&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=205699&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 386647 from bug 205699.
Fetching: https://bugs.webkit.org/attachment.cgi?id=386647
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/imported/w3c/ChangeLog
	M	LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.window-expected.txt
	M	Source/WebCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date
W: 148a62757011498dec09eed65fb925add1e38d23 and refs/remotes/origin/master differ, using rebase:
:040000 040000 01097f43b7b4a5d53f88afb25d40c6c84e386074 08fb29d6be41ea5db14a4f5b6a94bf9259114c69 M	LayoutTests
:040000 040000 40b8ac37e0b3d524e157d6586d6cae933c1c731f a1b0e40332200b3dad7c924ad35adeccd3fb0c55 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/imported/w3c/ChangeLog
	M	LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.window-expected.txt
	M	Source/WebCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date
W: 148a62757011498dec09eed65fb925add1e38d23 and refs/remotes/origin/master differ, using rebase:
:040000 040000 01097f43b7b4a5d53f88afb25d40c6c84e386074 08fb29d6be41ea5db14a4f5b6a94bf9259114c69 M	LayoutTests
:040000 040000 40b8ac37e0b3d524e157d6586d6cae933c1c731f a1b0e40332200b3dad7c924ad35adeccd3fb0c55 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   22a9ed66c88..4642e1144c0  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 253986 = 22a9ed66c888918a8ce48ac0ec10d46040dec0c6
r253987 = 4642e1144c05c0c1d3d80d7c9f0ce605a4b0edb6
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13298353

[Chris Dumez]

Committed r254001: <https://trac.webkit.org/changeset/254001>

[Radar WebKit Bug Importer]

<rdar://problem/58298800>