Bug 205693 – [LFC][Integration] Fix failing text-indent cases when the IFC root is an anonymous box

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[Radar WebKit Bug Importer]

<rdar://problem/58284277>

[zalan]

Created attachment 386633 [details]
Patch

[zalan]

Fixes the following cases

* css2.1/20110323/text-indent-014.htm 
* fast/css/text-indent-first-line-001.html
* fast/css/text-indent-first-line-004.html
* fast/css/text-indent-first-line-005.html
* fast/css/text-indent-first-line-006.html

[Antti Koivisto]

Comment on attachment 386633 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386633&action=review

> Source/WebCore/layout/LayoutState.h:83
> +    bool isIntegratedRootBoxFirstChild() const { return m_layoutTreeContent->isRootFirstChild(); }

Can't this bit (and any other integration hacks) just be in LayoutState like the viewport size?

[zalan]

(In reply to Antti Koivisto from comment #4)
> Comment on attachment 386633 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386633&action=review
> 
> > Source/WebCore/layout/LayoutState.h:83
> > +    bool isIntegratedRootBoxFirstChild() const { return m_layoutTreeContent->isRootFirstChild(); }
> 
> Can't this bit (and any other integration hacks) just be in LayoutState like
> the viewport size?
Yeah, let me move it in there.

[zalan]

Created attachment 386636 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 386636 [details]
Patch

Clearing flags on attachment: 386636

Committed r253985: <https://trac.webkit.org/changeset/253985>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.