Bug 205692 - Improve release logging in ServiceWorkerFetchTask
Summary: Improve release logging in ServiceWorkerFetchTask
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2020-01-02 14:01 PST by Chris Dumez
Modified: 2020-01-03 09:25 PST (History)
6 users (show)

See Also:

Patch (9.64 KB, patch)
2020-01-02 14:04 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (10.13 KB, patch)
2020-01-03 09:04 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-01-02 14:01:42 PST
Improve release logging in ServiceWorkerFetchTask to facilitate debugging.
Comment 1 Chris Dumez 2020-01-02 14:04:25 PST
Created attachment 386628 [details]
Comment 2 Keith Rollin 2020-01-02 15:40:16 PST
Looks good to me.
Comment 3 youenn fablet 2020-01-03 01:04:43 PST
Comment on attachment 386628 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=386628&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:252
> +        RELEASE_LOG_IF_ALLOWED("softUpdateIfNeeded: Scheduling soft update");

Would probably be better added in SWServerRegistration::scheduleSoftUpdate given scheduleSoftUpdate is called in two places.
Comment 4 Chris Dumez 2020-01-03 09:04:41 PST
Created attachment 386688 [details]
Comment 5 Chris Dumez 2020-01-03 09:24:12 PST
Comment on attachment 386688 [details]

Clearing flags on attachment: 386688

Committed r254002: <https://trac.webkit.org/changeset/254002>
Comment 6 Chris Dumez 2020-01-03 09:24:15 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-03 09:25:25 PST