RESOLVED FIXED 205692
Improve release logging in ServiceWorkerFetchTask 
https://bugs.webkit.org/show_bug.cgi?id=205692
Summary Improve release logging in ServiceWorkerFetchTask
Chris Dumez
Reported 2020-01-02 14:01:42 PST
Improve release logging in ServiceWorkerFetchTask to facilitate debugging.
Attachments
Patch (9.64 KB, patch)
2020-01-02 14:04 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.13 KB, patch)
2020-01-03 09:04 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-01-02 14:04:25 PST
Created attachment 386628 [details] Patch
Keith Rollin
Comment 2 2020-01-02 15:40:16 PST
Looks good to me.
youenn fablet
Comment 3 2020-01-03 01:04:43 PST
Comment on attachment 386628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386628&action=review > Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:252 > + RELEASE_LOG_IF_ALLOWED("softUpdateIfNeeded: Scheduling soft update"); Would probably be better added in SWServerRegistration::scheduleSoftUpdate given scheduleSoftUpdate is called in two places.
Chris Dumez
Comment 4 2020-01-03 09:04:41 PST
Created attachment 386688 [details] Patch
Chris Dumez
Comment 5 2020-01-03 09:24:12 PST
Comment on attachment 386688 [details] Patch Clearing flags on attachment: 386688 Committed r254002: <https://trac.webkit.org/changeset/254002>
Chris Dumez
Comment 6 2020-01-03 09:24:15 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-01-03 09:25:25 PST
<rdar://problem/58299315>
Note You need to log in before you can comment on or make changes to this bug.