Bug 205681 - Remove document.origin
Summary: Remove document.origin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-02 00:24 PST by Anne van Kesteren
Modified: 2020-01-07 18:09 PST (History)
28 users (show)

See Also:


Attachments
Patch (25.93 KB, patch)
2020-01-06 15:34 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (27.35 KB, patch)
2020-01-06 15:53 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (39.56 KB, patch)
2020-01-06 16:54 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Alexey Proskuryakov 2020-01-03 20:31:00 PST
Do window-less documents, like those fetched by XHR or produced by XSLT, have a document.origin?
Comment 2 Anne van Kesteren 2020-01-03 23:41:13 PST
They used to, though what exactly that returned wasn't consistent (and also not really useful in any meaningful sense).
Comment 3 Chris Dumez 2020-01-06 08:44:24 PST
Looks like WebKit is the last engine to ship this.
Comment 4 Chris Dumez 2020-01-06 15:34:18 PST
Created attachment 386898 [details]
Patch
Comment 5 Chris Dumez 2020-01-06 15:53:18 PST
Created attachment 386905 [details]
Patch
Comment 6 EWS Watchlist 2020-01-06 15:54:09 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 7 Chris Dumez 2020-01-06 16:54:05 PST
Created attachment 386915 [details]
Patch
Comment 8 Chris Dumez 2020-01-07 16:30:04 PST
ping review?
Comment 9 Geoffrey Garen 2020-01-07 17:00:06 PST
Comment on attachment 386915 [details]
Patch

r=me
Comment 10 WebKit Commit Bot 2020-01-07 18:08:11 PST
Comment on attachment 386915 [details]
Patch

Clearing flags on attachment: 386915

Committed r254182: <https://trac.webkit.org/changeset/254182>
Comment 11 WebKit Commit Bot 2020-01-07 18:08:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2020-01-07 18:09:17 PST
<rdar://problem/58395584>