WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 205681
Remove document.origin
https://bugs.webkit.org/show_bug.cgi?id=205681
Summary
Remove document.origin
Anne van Kesteren
Reported
2020-01-02 00:24:55 PST
See
https://github.com/whatwg/dom/pull/815
and
https://github.com/web-platform-tests/wpt/pull/20995
.
https://github.com/whatwg/dom/issues/410
has context.
Attachments
Patch
(25.93 KB, patch)
2020-01-06 15:34 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(27.35 KB, patch)
2020-01-06 15:53 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(39.56 KB, patch)
2020-01-06 16:54 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2020-01-03 20:31:00 PST
Do window-less documents, like those fetched by XHR or produced by XSLT, have a document.origin?
Anne van Kesteren
Comment 2
2020-01-03 23:41:13 PST
They used to, though what exactly that returned wasn't consistent (and also not really useful in any meaningful sense).
Chris Dumez
Comment 3
2020-01-06 08:44:24 PST
Looks like WebKit is the last engine to ship this.
Chris Dumez
Comment 4
2020-01-06 15:34:18 PST
Created
attachment 386898
[details]
Patch
Chris Dumez
Comment 5
2020-01-06 15:53:18 PST
Created
attachment 386905
[details]
Patch
EWS Watchlist
Comment 6
2020-01-06 15:54:09 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See
http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Chris Dumez
Comment 7
2020-01-06 16:54:05 PST
Created
attachment 386915
[details]
Patch
Chris Dumez
Comment 8
2020-01-07 16:30:04 PST
ping review?
Geoffrey Garen
Comment 9
2020-01-07 17:00:06 PST
Comment on
attachment 386915
[details]
Patch r=me
WebKit Commit Bot
Comment 10
2020-01-07 18:08:11 PST
Comment on
attachment 386915
[details]
Patch Clearing flags on attachment: 386915 Committed
r254182
: <
https://trac.webkit.org/changeset/254182
>
WebKit Commit Bot
Comment 11
2020-01-07 18:08:14 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12
2020-01-07 18:09:17 PST
<
rdar://problem/58395584
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug