Bug 205655 - StyleRule accessor in RuleData should return a const reference
Summary: StyleRule accessor in RuleData should return a const reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-31 04:04 PST by Antti Koivisto
Modified: 2019-12-31 08:16 PST (History)
16 users (show)

See Also:

Attachments
patch (25.06 KB, patch)
2019-12-31 04:14 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (25.04 KB, patch)
2019-12-31 04:49 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (25.18 KB, patch)
2019-12-31 05:33 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (27.07 KB, patch)
2019-12-31 05:57 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (27.74 KB, patch)
2019-12-31 06:12 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-12-31 04:04:46 PST 
Instead of a non-const pointer.
Comment 1 Antti Koivisto 2019-12-31 04:14:57 PST 
Created attachment 386554 [details]
patch
Comment 2 Antti Koivisto 2019-12-31 04:49:16 PST 
Created attachment 386556 [details]
patch
Comment 3 Antti Koivisto 2019-12-31 05:33:23 PST 
Created attachment 386558 [details]
patch
Comment 4 Antti Koivisto 2019-12-31 05:57:07 PST 
Created attachment 386559 [details]
patch
Comment 5 Antti Koivisto 2019-12-31 06:12:23 PST 
Created attachment 386560 [details]
patch
Comment 6 zalan 2019-12-31 07:15:03 PST 
Comment on attachment 386560 [details]
patch

nice
Comment 7 WebKit Commit Bot 2019-12-31 08:15:17 PST 
Comment on attachment 386560 [details]
patch

Clearing flags on attachment: 386560

Committed r253959: <https://trac.webkit.org/changeset/253959>
Comment 8 WebKit Commit Bot 2019-12-31 08:15:19 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-12-31 08:16:18 PST 
<rdar://problem/58254381>