Bug 205638 - Re-sync web-platform-tests/domparsing from upstream
Summary: Re-sync web-platform-tests/domparsing from upstream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pablo Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-30 00:25 PST by Pablo Saavedra
Modified: 2020-01-07 08:32 PST (History)
5 users (show)

See Also:

Attachments
patch (12.51 KB, patch)
2019-12-30 00:27 PST, Pablo Saavedra 		no flags Details | Formatted Diff | Diff
patch (27.96 KB, patch)
2019-12-30 01:31 PST, Pablo Saavedra 		no flags Details | Formatted Diff | Diff
patch (37.12 KB, patch)
2019-12-30 05:03 PST, Pablo Saavedra 		no flags Details | Formatted Diff | Diff
patch (37.12 KB, patch)
2020-01-03 00:31 PST, Pablo Saavedra 		no flags Details | Formatted Diff | Diff
patch (1.94 KB, patch)
2020-01-03 00:52 PST, Pablo Saavedra 		no flags Details | Formatted Diff | Diff
patch (1.95 KB, patch)
2020-01-03 00:58 PST, Pablo Saavedra 		no flags Details | Formatted Diff | Diff
patch (1.90 KB, patch)
2020-01-06 23:41 PST, Pablo Saavedra 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Saavedra 2019-12-30 00:25:20 PST 
Re-sync web-platform-tests/domparsing from upstream
Comment 1 Pablo Saavedra 2019-12-30 00:27:25 PST 
Created attachment 386511 [details]
patch
Comment 2 Pablo Saavedra 2019-12-30 01:31:02 PST 
Created attachment 386517 [details]
patch
Comment 3 Pablo Saavedra 2019-12-30 05:03:12 PST 
Created attachment 386524 [details]
patch
Comment 4 Carlos Alberto Lopez Perez 2019-12-30 08:32:18 PST 
Comment on attachment 386524 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386524&action=review

It looks there are some failures on the EWS with this last version of the patch.

> LayoutTests/imported/w3c/resources/import-expectations.json:159
>      "web-platform-tests/domparsing": "import", 
> -    "web-platform-tests/domparsing/DOMParser-parseFromString-xml-doctype.html": "skip", 
> -    "web-platform-tests/domparsing/DOMParser-parseFromString-xml.html": "skip", 
> -    "web-platform-tests/domparsing/XMLSerializer-serializeToString.html": "skip", 
> -    "web-platform-tests/domparsing/innerhtml-02.html": "skip", 
> -    "web-platform-tests/domparsing/insert_adjacent_html-xhtml.xhtml": "skip", 
> -    "web-platform-tests/domparsing/style_attribute_html.html": "skip", 
> +    "web-platform-tests/domparsing/": "import", 

I know this is tool-generated. But this added line looks like its not needed?
There is already a '"web-platform-tests/domparsing": "import",' line above
Comment 5 Pablo Saavedra 2020-01-03 00:31:22 PST 
Created attachment 386665 [details]
patch
Comment 6 Pablo Saavedra 2020-01-03 00:32:56 PST 
(In reply to Carlos Alberto Lopez Perez from comment #4)
> Comment on attachment 386524 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386524&action=review
> 
> It looks there are some failures on the EWS with this last version of the
> patch.
> 
> > LayoutTests/imported/w3c/resources/import-expectations.json:159
> >      "web-platform-tests/domparsing": "import", 
> > -    "web-platform-tests/domparsing/DOMParser-parseFromString-xml-doctype.html": "skip", 
> > -    "web-platform-tests/domparsing/DOMParser-parseFromString-xml.html": "skip", 
> > -    "web-platform-tests/domparsing/XMLSerializer-serializeToString.html": "skip", 
> > -    "web-platform-tests/domparsing/innerhtml-02.html": "skip", 
> > -    "web-platform-tests/domparsing/insert_adjacent_html-xhtml.xhtml": "skip", 
> > -    "web-platform-tests/domparsing/style_attribute_html.html": "skip", 
> > +    "web-platform-tests/domparsing/": "import", 
> 
> I know this is tool-generated. But this added line looks like its not needed?
> There is already a '"web-platform-tests/domparsing": "import",' line above

I see. This is fixed in the latest version of the patch.

... checking right now the errors show by the EWS.
Comment 7 Pablo Saavedra 2020-01-03 00:48:31 PST 
This issue was surpassed by https://bugs.webkit.org/show_bug.cgi?id=205696.
Comment 8 Pablo Saavedra 2020-01-03 00:52:35 PST 
Created attachment 386666 [details]
patch
Comment 9 Pablo Saavedra 2020-01-03 00:55:24 PST 
Rebasing this patch in the top of the work done by Chris Dumez in https://bugs.webkit.org/show_bug.cgi?id=205696.  Only the update of the import-expectations.json file looks like missing. Let's wait for his opinion about if this last change is really necessary or not.
Comment 10 Pablo Saavedra 2020-01-03 00:58:07 PST 
Created attachment 386667 [details]
patch
Comment 11 Carlos Alberto Lopez Perez 2020-01-03 07:51:57 PST 
Comment on attachment 386667 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386667&action=review

> LayoutTests/imported/w3c/resources/import-expectations.json:159
>      "web-platform-tests/domparsing": "import", 
> -    "web-platform-tests/domparsing/DOMParser-parseFromString-xml-doctype.html": "skip", 
> -    "web-platform-tests/domparsing/DOMParser-parseFromString-xml.html": "skip", 
> -    "web-platform-tests/domparsing/XMLSerializer-serializeToString.html": "skip", 
> -    "web-platform-tests/domparsing/innerhtml-02.html": "skip", 
> -    "web-platform-tests/domparsing/insert_adjacent_html-xhtml.xhtml": "skip", 
> -    "web-platform-tests/domparsing/style_attribute_html.html": "skip", 
> +    "web-platform-tests/domparsing/": "import", 

In the end, after this patch, this would be:


"web-platform-tests/domparsing": "import", 
"web-platform-tests/domparsing/": "import", 


So I think the last line added is not needed, looks superfluous.
Comment 12 Pablo Saavedra 2020-01-06 23:41:52 PST 
Created attachment 386937 [details]
patch
Comment 13 Pablo Saavedra 2020-01-07 07:27:14 PST 
The fails in ios-wk2 and api-ios look like nothing to do respect the changes reported by this patch.
Comment 14 WebKit Commit Bot 2020-01-07 08:31:16 PST 
Comment on attachment 386937 [details]
patch

Clearing flags on attachment: 386937

Committed r254128: <https://trac.webkit.org/changeset/254128>
Comment 15 WebKit Commit Bot 2020-01-07 08:31:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 16 Radar WebKit Bug Importer 2020-01-07 08:32:12 PST 
<rdar://problem/58375157>