Bug 205623 – [LFC][IFC] Add LineBreaker::Result::Revert to indicate an earlier line wrap opportunity

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[Radar WebKit Bug Importer]

<rdar://problem/58228339>

[zalan]

Created attachment 386480 [details]
Patch

[Antti Koivisto]

Comment on attachment 386480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386480&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:140
> -        return { Result::Action::Keep, IsEndOfLine::No, { } };
> +        return Result { Result::Action::Keep };

Why name the type here and elsewhere?

> Source/WebCore/layout/inlineformatting/InlineLineBreaker.h:66
> +        Result(Action, IsEndOfLine = IsEndOfLine::No, Optional<PartialTrailingContent> = WTF::nullopt, const InlineItem* revertTo = nullptr);
> +
> +        Action action { Action::Keep };
> +        IsEndOfLine isEndOfLine { IsEndOfLine::No };
>          Optional<PartialTrailingContent> partialTrailingContent;
> +        const InlineItem* revertTo { nullptr };
>      };

I don't think you need a constructor if you make it

Optional<PartialTrailingContent> partialTrailingContent { };

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 386480 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386480&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:140
> > -        return { Result::Action::Keep, IsEndOfLine::No, { } };
> > +        return Result { Result::Action::Keep };
> 
> Why name the type here and elsewhere?
Because I did not pay attention?

> 
> > Source/WebCore/layout/inlineformatting/InlineLineBreaker.h:66
> > +        Result(Action, IsEndOfLine = IsEndOfLine::No, Optional<PartialTrailingContent> = WTF::nullopt, const InlineItem* revertTo = nullptr);
> > +
> > +        Action action { Action::Keep };
> > +        IsEndOfLine isEndOfLine { IsEndOfLine::No };
> >          Optional<PartialTrailingContent> partialTrailingContent;
> > +        const InlineItem* revertTo { nullptr };
> >      };
> 
> I don't think you need a constructor if you make it
> 
> Optional<PartialTrailingContent> partialTrailingContent { };
oh cool

[zalan]

Created attachment 386492 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 386492 [details]:

imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html bug 203433
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 386492 [details]
Patch

Clearing flags on attachment: 386492

Committed r253937: <https://trac.webkit.org/changeset/253937>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.