Bug 20562 - WebKitCSSTransformValue.idl operation types don't match the implementation
Summary: WebKitCSSTransformValue.idl operation types don't match the implementation
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
Depends on:
Reported: 2008-08-28 15:38 PDT by Simon Fraser (smfr)
Modified: 2008-08-28 16:04 PDT (History)
1 user (show)

See Also:

Patch, testcase, changelog (9.50 KB, patch)
2008-08-28 15:41 PDT, Simon Fraser (smfr)
hyatt: review-
Details | Formatted Diff | Diff
Fixed patch, testcase (12.47 KB, patch)
2008-08-28 15:51 PDT, Simon Fraser (smfr)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2008-08-28 15:38:19 PDT
WebKitCSSTransformValue has a number of issues:
1. the OperationType consts don't match the implementation
2. The order of operations is weird (tho it does need to match the spec)
3. getPropertyCSSValue('-webkit-transform') doesn't return a WebKitCSSTransformValue, but a CSSValueList
Comment 1 Simon Fraser (smfr) 2008-08-28 15:41:02 PDT
Created attachment 23061 [details]
Patch, testcase, changelog
Comment 2 Simon Fraser (smfr) 2008-08-28 15:43:29 PDT
Gonna remove this too:
        // Note there are gaps because the proposed specification
        // has other types that are not implemented yet

Comment 3 Dave Hyatt 2008-08-28 15:44:48 PDT
Comment on attachment 23061 [details]
Patch, testcase, changelog

Please do scaleX and not scalex to match the spec (same for the other ops).
Comment 4 Simon Fraser (smfr) 2008-08-28 15:51:43 PDT
Created attachment 23062 [details]
Fixed patch, testcase
Comment 5 Dave Hyatt 2008-08-28 15:52:16 PDT
Comment on attachment 23062 [details]
Fixed patch, testcase

Comment 6 Simon Fraser (smfr) 2008-08-28 16:04:30 PDT
Committed r35983
	M	WebCore/bindings/js/JSCSSValueCustom.cpp
	M	WebCore/ChangeLog
	M	WebCore/css/CSSValue.h
	M	WebCore/css/WebKitCSSTransformValue.h
	M	WebCore/css/WebKitCSSTransformValue.idl
	M	WebCore/css/WebKitCSSTransformValue.cpp
	M	LayoutTests/ChangeLog
	A	LayoutTests/css3/transform-value-types-expected.txt
	A	LayoutTests/css3/transform-value-types.html
r35983 = 8f30d02092e53e5ffb672f82d88b04e0ad86cdbc (trunk)