WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
205613
[LFC][IFC] Keep the LineBreaker object around until after the line is closed.
https://bugs.webkit.org/show_bug.cgi?id=205613
Summary
[LFC][IFC] Keep the LineBreaker object around until after the line is closed.
zalan
Reported
2019-12-27 20:21:00 PST
This is in preparation for being able to point to an earlier wrapping opportunity.
Attachments
Patch
(24.49 KB, patch)
2019-12-27 20:53 PST
,
zalan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2019-12-27 20:21:22 PST
<
rdar://problem/58222870
>
zalan
Comment 2
2019-12-27 20:41:11 PST
In order to be able to point back to an earlier line wrap opportunity on the line e.g. <div style="white-space: pre"><span style="white-space: normal">earlier_wrap opportunities</span> <span>can't_wrap_this content</span></div> the LineBreaker class needs more context. Currently (taking the example above), if the available space runs out somewhere around the second <span> we would just simply overflow the line since the overflowing content has a style saying "do not wrap". However the line has multiple earlier wrap opportunities inside the first <span>. Since we construct a LineBreaker object for each continuous run 1. [container start][earlier_wrap] 2. [ ] 3. [opportunities][container end] 4. [ ] 5. [container start][can't_wrap_this] 6. [ ] 7. [content][container end] the LineBreaker does not have enough context to point back to the last line wrap opportunity (after run #3).
zalan
Comment 3
2019-12-27 20:53:00 PST
Created
attachment 386463
[details]
Patch
WebKit Commit Bot
Comment 4
2019-12-28 08:08:05 PST
Comment on
attachment 386463
[details]
Patch Clearing flags on attachment: 386463 Committed
r253924
: <
https://trac.webkit.org/changeset/253924
>
WebKit Commit Bot
Comment 5
2019-12-28 08:08:07 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug