Bug 205604 - [WebGL] Add a pure virtual base class for GraphicsContext3D
Summary: [WebGL] Add a pure virtual base class for GraphicsContext3D
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on: 205648
Blocks:
  Show dependency tree / graph
 
Reported: 2019-12-27 02:08 PST by Dean Jackson
Modified: 2020-01-03 08:19 PST (History)
20 users (show)

See Also:

Attachments
Patch (338.29 KB, patch)
2019-12-27 02:22 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (369.03 KB, patch)
2019-12-27 12:24 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (371.75 KB, patch)
2019-12-27 13:40 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (373.67 KB, patch)
2019-12-27 14:05 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (375.77 KB, patch)
2019-12-27 14:29 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (376.76 KB, patch)
2019-12-27 16:18 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (377.08 KB, patch)
2019-12-28 12:09 PST, Dean Jackson 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-12-27 02:08:25 PST 
[WebGL] Add a pure virtual base class for GraphicsContext3D
Comment 1 Dean Jackson 2019-12-27 02:22:59 PST 
Created attachment 386436 [details]
Patch
Comment 2 Sam Weinig 2019-12-27 12:03:13 PST 
I think this would be easier to process if you split the enum renaming into its own change first.

Also, can you remind me, is GraphicsContext3D a generic 3D context that is used for both WebGL and WebGPU? If it's not really generic to anything but an OpenGL/OpenGLES/ANGLE backend, perhaps we should take this opportunity to rename it?
Comment 3 Dean Jackson 2019-12-27 12:24:31 PST 
Created attachment 386451 [details]
Patch
Comment 4 Dean Jackson 2019-12-27 13:29:28 PST 
(In reply to Sam Weinig from comment #2)
> I think this would be easier to process if you split the enum renaming into
> its own change first.

Agreed (although now extra work!)

> 
> Also, can you remind me, is GraphicsContext3D a generic 3D context that is
> used for both WebGL and WebGPU? If it's not really generic to anything but
> an OpenGL/OpenGLES/ANGLE backend, perhaps we should take this opportunity to
> rename it?

It is just for GLES/WebGL-like things, so maybe it should be called GraphicsContextGL?
Comment 5 Dean Jackson 2019-12-27 13:40:26 PST 
Created attachment 386454 [details]
Patch
Comment 6 Dean Jackson 2019-12-27 14:05:17 PST 
Created attachment 386456 [details]
Patch
Comment 7 Dean Jackson 2019-12-27 14:29:48 PST 
Created attachment 386457 [details]
Patch
Comment 8 Dean Jackson 2019-12-27 16:18:13 PST 
Created attachment 386458 [details]
Patch
Comment 9 Dean Jackson 2019-12-28 12:09:30 PST 
Created attachment 386473 [details]
Patch
Comment 10 Dean Jackson 2019-12-29 13:43:40 PST 
Committed r253939: <https://trac.webkit.org/changeset/253939>
Comment 11 Radar WebKit Bug Importer 2019-12-29 13:44:17 PST 
<rdar://problem/58233288>
Comment 12 Aakash Jain 2020-01-03 08:17:10 PST Comment hidden (obsolete)