[WebGL] Add a pure virtual base class for GraphicsContext3D
Created attachment 386436 [details] Patch
I think this would be easier to process if you split the enum renaming into its own change first. Also, can you remind me, is GraphicsContext3D a generic 3D context that is used for both WebGL and WebGPU? If it's not really generic to anything but an OpenGL/OpenGLES/ANGLE backend, perhaps we should take this opportunity to rename it?
Created attachment 386451 [details] Patch
(In reply to Sam Weinig from comment #2) > I think this would be easier to process if you split the enum renaming into > its own change first. Agreed (although now extra work!) > > Also, can you remind me, is GraphicsContext3D a generic 3D context that is > used for both WebGL and WebGPU? If it's not really generic to anything but > an OpenGL/OpenGLES/ANGLE backend, perhaps we should take this opportunity to > rename it? It is just for GLES/WebGL-like things, so maybe it should be called GraphicsContextGL?
Created attachment 386454 [details] Patch
Created attachment 386456 [details] Patch
Created attachment 386457 [details] Patch
Created attachment 386458 [details] Patch
Created attachment 386473 [details] Patch
Committed r253939: <https://trac.webkit.org/changeset/253939>
<rdar://problem/58233288>
(In reply to Dean Jackson from comment #10) > Committed r253939: <https://trac.webkit.org/changeset/253939>
(In reply to Dean Jackson from comment #10) > Committed r253939: <https://trac.webkit.org/changeset/253939> This might have broken wincairo build. Please check. r253938 passed in https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/14464 r253939 failed in https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/14465 Similarly on Debug: r253938 passed in https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/12882 r253939 failed in https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/12883