Bug 205572 - Web Inspector: Color picker: make it keyboard accessible
Summary: Web Inspector: Color picker: make it keyboard accessible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-23 15:43 PST by Nikita Vasilyev
Modified: 2020-01-06 15:55 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.46 KB, patch)
2019-12-23 15:52 PST, Nikita Vasilyev
bburg: review+
bburg: commit-queue-
Details | Formatted Diff | Diff
Pach (8.07 KB, patch)
2020-01-06 13:51 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-12-23 15:43:59 PST
For the Color Square, up/down/left/right keys should move the "crosshair".

For the hue and opacity sliders:
- Pressing up and down keys should adjust the value by 1%.
- When holding Shift, up and down keys adjust the value by 10%.
Comment 1 Radar WebKit Bug Importer 2019-12-23 15:44:18 PST
<rdar://problem/58169943>
Comment 2 Nikita Vasilyev 2019-12-23 15:52:50 PST
Created attachment 386363 [details]
Patch
Comment 3 BJ Burg 2020-01-06 10:56:59 PST
Comment on attachment 386363 [details]
Patch

r=me, with one issue.

Whenever I use arrows, I get the Bonking noise (InspectorFrontendHost.beep()?) that happens when  the default event handler runs. So I think you need to call .preventDefault() on the event after handling it.
Comment 4 Nikita Vasilyev 2020-01-06 13:51:21 PST
Created attachment 386882 [details]
Pach
Comment 5 WebKit Commit Bot 2020-01-06 15:55:42 PST
Comment on attachment 386882 [details]
Pach

Clearing flags on attachment: 386882

Committed r254094: <https://trac.webkit.org/changeset/254094>
Comment 6 WebKit Commit Bot 2020-01-06 15:55:44 PST
All reviewed patches have been landed.  Closing bug.