Bug 205570 - REGRESSION(r218839): Web Inspector: Color picker: pressing Esc should hide color picker
Summary: REGRESSION(r218839): Web Inspector: Color picker: pressing Esc should hide co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-23 15:36 PST by Nikita Vasilyev
Modified: 2020-01-06 10:24 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2019-12-24 17:35 PST, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2020-01-03 18:41 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-12-23 15:36:20 PST 
There's relevant code in Popover.js but it doesn't work:

    handleEvent(event)
    {
        switch (event.type) {
        ...
        case "keypress":
            if (event.keyCode === WI.KeyboardShortcut.Key.Escape.keyCode)
                this.dismiss();
Comment 1 Radar WebKit Bug Importer 2019-12-23 15:36:35 PST 
<rdar://problem/58169820>
Comment 2 Nikita Vasilyev 2019-12-24 17:21:26 PST 
Regressed in r218839 as `keyboardShortcutDisabled` getter was removed:

https://github.com/WebKit/webkit/commit/9870d084e62af3e5a9240390f46c7a61a4ce40a0#diff-a644aa8b89b6359edd1f27853c18a8faL106
Comment 3 Nikita Vasilyev 2019-12-24 17:35:01 PST Comment hidden (obsolete)
Comment 4 Nikita Vasilyev 2020-01-03 18:39:30 PST 
Comment on attachment 386395 [details]
Patch

This only works every other time.
Comment 5 Nikita Vasilyev 2020-01-03 18:41:01 PST 
Created attachment 386741 [details]
Patch
Comment 6 BJ Burg 2020-01-06 09:21:47 PST 
Comment on attachment 386741 [details]
Patch

r=me, good catch.
Comment 7 WebKit Commit Bot 2020-01-06 10:24:34 PST 
Comment on attachment 386741 [details]
Patch

Clearing flags on attachment: 386741

Committed r254061: <https://trac.webkit.org/changeset/254061>
Comment 8 WebKit Commit Bot 2020-01-06 10:24:36 PST 
All reviewed patches have been landed.  Closing bug.