RESOLVED FIXED Bug 205570
REGRESSION(r218839): Web Inspector: Color picker: pressing Esc should hide color picker 
https://bugs.webkit.org/show_bug.cgi?id=205570
Summary REGRESSION(r218839): Web Inspector: Color picker: pressing Esc should hide co...
Nikita Vasilyev
Reported 2019-12-23 15:36:20 PST
There's relevant code in Popover.js but it doesn't work: handleEvent(event) { switch (event.type) { ... case "keypress": if (event.keyCode === WI.KeyboardShortcut.Key.Escape.keyCode) this.dismiss();
Attachments
Patch (1.48 KB, patch)
2019-12-24 17:35 PST, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
DetailsFormatted DiffDiff
Patch (2.33 KB, patch)
2020-01-03 18:41 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-23 15:36:35 PST
<rdar://problem/58169820>
Nikita Vasilyev
Comment 2 2019-12-24 17:21:26 PST
Regressed in r218839 as `keyboardShortcutDisabled` getter was removed: https://github.com/WebKit/webkit/commit/9870d084e62af3e5a9240390f46c7a61a4ce40a0#diff-a644aa8b89b6359edd1f27853c18a8faL106
Nikita Vasilyev
Comment 3 2019-12-24 17:35:01 PST Comment hidden (obsolete)
Nikita Vasilyev
Comment 4 2020-01-03 18:39:30 PST
Comment on attachment 386395 [details] Patch This only works every other time.
Nikita Vasilyev
Comment 5 2020-01-03 18:41:01 PST
Created attachment 386741 [details] Patch
Blaze Burg
Comment 6 2020-01-06 09:21:47 PST
Comment on attachment 386741 [details] Patch r=me, good catch.
WebKit Commit Bot
Comment 7 2020-01-06 10:24:34 PST
Comment on attachment 386741 [details] Patch Clearing flags on attachment: 386741 Committed r254061: <https://trac.webkit.org/changeset/254061>
WebKit Commit Bot
Comment 8 2020-01-06 10:24:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.