Provide pid to crashing service worker process and GPU process
Created attachment 386348 [details] Patch
Comment on attachment 386348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386348&action=review > Source/WebKit/ChangeLog:8 > + No change of behavior, we provide pids to the WKContext callbacks. Why are we doing this to the C API rather than the Objective-C/Swift API?
(In reply to Darin Adler from comment #2) > Comment on attachment 386348 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386348&action=review > > > Source/WebKit/ChangeLog:8 > > + No change of behavior, we provide pids to the WKContext callbacks. > > Why are we doing this to the C API rather than the Objective-C/Swift API? We could do both but the only use case is to allow better WebKitTestRunner error reporting and the API in use is the cross platform C API.
Comment on attachment 386348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386348&action=review > Source/WebKit/UIProcess/API/C/WKContext.h:60 > typedef void (*WKContextChildProcessDidCrashCallback)(WKContextRef context, const void *clientInfo); > typedef WKContextChildProcessDidCrashCallback WKContextNetworkProcessDidCrashCallback; Are these still needed. > Source/WebKit/UIProcess/API/C/WKContext.h:116 > - WKContextChildProcessDidCrashCallback serviceWorkerProcessDidCrash; > - WKContextChildProcessDidCrashCallback gpuProcessDidCrash; > + WKContextChildProcessWithPIDDidCrashCallback serviceWorkerProcessDidCrash; > + WKContextChildProcessWithPIDDidCrashCallback gpuProcessDidCrash; This is not a binary-compatible change. Do we have any clients using these except WebKitTestRunner? If so, we will need to add WKContextClientV4
Comment on attachment 386348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386348&action=review >> Source/WebKit/UIProcess/API/C/WKContext.h:60 >> typedef WKContextChildProcessDidCrashCallback WKContextNetworkProcessDidCrashCallback; > > Are these still needed. Yes, WKContextNetworkProcessDidCrashCallback is still in use. >> Source/WebKit/UIProcess/API/C/WKContext.h:116 >> + WKContextChildProcessWithPIDDidCrashCallback gpuProcessDidCrash; > > This is not a binary-compatible change. Do we have any clients using these except WebKitTestRunner? If so, we will need to add WKContextClientV4 serviceWorkerProcessDidCrash and gpuProcessDidCrash have been recently added mid December 2019 and at that time, the version was incremented.
Comment on attachment 386348 [details] Patch Clearing flags on attachment: 386348 Committed r254006: <https://trac.webkit.org/changeset/254006>
All reviewed patches have been landed. Closing bug.
<rdar://problem/58300321>
Comment on attachment 386348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386348&action=review > Source/WebKit/UIProcess/API/C/WKContext.h:62 > +using WKContextChildProcessWithPIDDidCrashCallback = void (*)(WKContextRef, WKProcessID, const void *clientInfo); As pointed out by Keith Rollin, this line needs to be as follows because this is a C API: typedef void (*WKContextChildProcessWithPIDDidCrashCallback)(WKContextRef context, WKProcessID processID, const void *clientInfo);
Fixed in r254012
(In reply to Dean Jackson from comment #10) > Fixed in r254012 Thanks!