Bug 205560 - [GTK][WPE] Remove duplicated code
Summary: [GTK][WPE] Remove duplicated code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-23 09:02 PST by Carlos Garcia Campos
Modified: 2020-01-08 00:21 PST (History)
3 users (show)

See Also:


Attachments
Patch (9.64 KB, patch)
2019-12-23 09:04 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (9.64 KB, patch)
2019-12-23 09:10 PST, Carlos Garcia Campos
svillar: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-12-23 09:02:01 PST
There's some duplicated code related to IME between GTK and WPE that can be shared.
Comment 1 Carlos Garcia Campos 2019-12-23 09:04:19 PST
Created attachment 386343 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-12-23 09:10:28 PST
Created attachment 386344 [details]
Patch
Comment 3 Carlos Garcia Campos 2019-12-26 02:12:32 PST
Committed r253914: <https://trac.webkit.org/changeset/253914>
Comment 4 Jonathan Bedard 2020-01-06 11:55:19 PST
legacy-animation-engine/animations/animation-iteration-event-destroy-renderer.html flakily regressed on GTK relatively recently.

Not something I'll be able to look into, but an automated regression detection script we're prototyping flagged this and provided this commit range: <https://results.webkit.org/commits?after_id=253908&before_id=253940>. The results themselves <https://results.webkit.org/?suite=layout-tests&test=legacy-animation-engine%2Fanimations%2Fanimation-iteration-event-destroy-renderer.html> seem to corroborate both the existence of the regression and the range, this is the only GTK specific patch in the range.
Comment 5 Carlos Garcia Campos 2020-01-08 00:21:04 PST
(In reply to Jonathan Bedard from comment #4)
> legacy-animation-engine/animations/animation-iteration-event-destroy-
> renderer.html flakily regressed on GTK relatively recently.
> 
> Not something I'll be able to look into, but an automated regression
> detection script we're prototyping flagged this and provided this commit
> range:
> <https://results.webkit.org/commits?after_id=253908&before_id=253940>. The
> results themselves
> <https://results.webkit.org/?suite=layout-tests&test=legacy-animation-
> engine%2Fanimations%2Fanimation-iteration-event-destroy-renderer.html> seem
> to corroborate both the existence of the regression and the range, this is
> the only GTK specific patch in the range.

weird, this is ime related code, I'll check it. Thanks.