WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
205560
[GTK][WPE] Remove duplicated code
https://bugs.webkit.org/show_bug.cgi?id=205560
Summary
[GTK][WPE] Remove duplicated code
Carlos Garcia Campos
Reported
2019-12-23 09:02:01 PST
There's some duplicated code related to IME between GTK and WPE that can be shared.
Attachments
Patch
(9.64 KB, patch)
2019-12-23 09:04 PST
,
Carlos Garcia Campos
no flags
Details
Formatted Diff
Diff
Patch
(9.64 KB, patch)
2019-12-23 09:10 PST
,
Carlos Garcia Campos
svillar
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2019-12-23 09:04:19 PST
Created
attachment 386343
[details]
Patch
Carlos Garcia Campos
Comment 2
2019-12-23 09:10:28 PST
Created
attachment 386344
[details]
Patch
Carlos Garcia Campos
Comment 3
2019-12-26 02:12:32 PST
Committed
r253914
: <
https://trac.webkit.org/changeset/253914
>
Jonathan Bedard
Comment 4
2020-01-06 11:55:19 PST
legacy-animation-engine/animations/animation-iteration-event-destroy-renderer.html flakily regressed on GTK relatively recently. Not something I'll be able to look into, but an automated regression detection script we're prototyping flagged this and provided this commit range: <
https://results.webkit.org/commits?after_id=253908&before_id=253940
>. The results themselves <
https://results.webkit.org/?suite=layout-tests&test=legacy-animation-engine%2Fanimations%2Fanimation-iteration-event-destroy-renderer.html
> seem to corroborate both the existence of the regression and the range, this is the only GTK specific patch in the range.
Carlos Garcia Campos
Comment 5
2020-01-08 00:21:04 PST
(In reply to Jonathan Bedard from
comment #4
)
> legacy-animation-engine/animations/animation-iteration-event-destroy- > renderer.html flakily regressed on GTK relatively recently. > > Not something I'll be able to look into, but an automated regression > detection script we're prototyping flagged this and provided this commit > range: > <
https://results.webkit.org/commits?after_id=253908&before_id=253940
>. The > results themselves > <
https://results.webkit.org/?suite=layout-tests&test=legacy-animation
- > engine%2Fanimations%2Fanimation-iteration-event-destroy-renderer.html> seem > to corroborate both the existence of the regression and the range, this is > the only GTK specific patch in the range.
weird, this is ime related code, I'll check it. Thanks.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug