Bug 205547 – [Media in GPU process] Add remote media player proxy configuration

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Add remote media player proxy configuration for static player properties.

[Radar WebKit Bug Importer]

<rdar://problem/58139762>

[Eric Carlson]

Created attachment 386312 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 386312 [details]
Patch

Clearing flags on attachment: 386312

Committed r253871: <https://trac.webkit.org/changeset/253871>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 386312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386312&action=review

> Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h:93
> +            WTFMove(*engineDescription),
> +            WTFMove(*supportsScanning),
> +            WTFMove(*supportsPictureInPicture),
> +            WTFMove(*supportsAcceleratedRendering),
> +            WTFMove(*canPlayToWirelessPlaybackTarget),

The WTFMove for engineDescription is fine. The others seem unnecessary. We don’t need to WTFMove a bool.

[Eric Carlson]

(In reply to Darin Adler from comment #5)
> Comment on attachment 386312 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386312&action=review
> 
> > Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h:93
> > +            WTFMove(*engineDescription),
> > +            WTFMove(*supportsScanning),
> > +            WTFMove(*supportsPictureInPicture),
> > +            WTFMove(*supportsAcceleratedRendering),
> > +            WTFMove(*canPlayToWirelessPlaybackTarget),
> 
> The WTFMove for engineDescription is fine. The others seem unnecessary. We
> don’t need to WTFMove a bool.

I will fix this in 205630.