Bug 205547 - [Media in GPU process] Add remote media player proxy configuration
Summary: [Media in GPU process] Add remote media player proxy configuration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks: 205123
  Show dependency tree / graph
 
Reported: 2019-12-21 19:58 PST by Eric Carlson
Modified: 2019-12-29 09:57 PST (History)
9 users (show)

See Also:

Attachments
Patch (26.95 KB, patch)
2019-12-21 21:34 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-12-21 19:58:32 PST 
Add remote media player proxy configuration for static player properties.
Comment 1 Radar WebKit Bug Importer 2019-12-21 19:58:42 PST 
<rdar://problem/58139762>
Comment 2 Eric Carlson 2019-12-21 21:34:55 PST 
Created attachment 386312 [details]
Patch
Comment 3 WebKit Commit Bot 2019-12-22 04:59:41 PST 
Comment on attachment 386312 [details]
Patch

Clearing flags on attachment: 386312

Committed r253871: <https://trac.webkit.org/changeset/253871>
Comment 4 WebKit Commit Bot 2019-12-22 04:59:43 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2019-12-26 17:39:10 PST 
Comment on attachment 386312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386312&action=review

> Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h:93
> +            WTFMove(*engineDescription),
> +            WTFMove(*supportsScanning),
> +            WTFMove(*supportsPictureInPicture),
> +            WTFMove(*supportsAcceleratedRendering),
> +            WTFMove(*canPlayToWirelessPlaybackTarget),

The WTFMove for engineDescription is fine. The others seem unnecessary. We don’t need to WTFMove a bool.
Comment 6 Eric Carlson 2019-12-29 09:57:11 PST 
(In reply to Darin Adler from comment #5)
> Comment on attachment 386312 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386312&action=review
> 
> > Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h:93
> > +            WTFMove(*engineDescription),
> > +            WTFMove(*supportsScanning),
> > +            WTFMove(*supportsPictureInPicture),
> > +            WTFMove(*supportsAcceleratedRendering),
> > +            WTFMove(*canPlayToWirelessPlaybackTarget),
> 
> The WTFMove for engineDescription is fine. The others seem unnecessary. We
> don’t need to WTFMove a bool.

I will fix this in 205630.