Bug 205543 - Very basic <dialog> show/close support
Summary: Very basic <dialog> show/close support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: dialog-element
  Show dependency tree / graph
 
Reported: 2019-12-21 12:51 PST by Simon Fraser (smfr)
Modified: 2019-12-22 19:57 PST (History)
17 users (show)

See Also:

Attachments
Patch (30.18 KB, patch)
2019-12-21 12:54 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (45.42 KB, patch)
2019-12-21 13:25 PST, Simon Fraser (smfr) 		koivisto: review+
Details | Formatted Diff | Diff
Patch (60.35 KB, patch)
2019-12-22 13:45 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-12-21 12:51:00 PST 
Very basic <dialog> show/close support
Comment 1 Simon Fraser (smfr) 2019-12-21 12:54:27 PST 
Created attachment 386301 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-12-21 13:25:42 PST 
Created attachment 386302 [details]
Patch
Comment 3 Antti Koivisto 2019-12-22 09:12:24 PST 
Comment on attachment 386302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386302&action=review

> Source/WebCore/style/UserAgentStyle.cpp:237
> +        else if (is<HTMLDialogElement>(element) && RuntimeEnabledFeatures::sharedFeatures().dialogElementEnabled()) {
> +            if (!dialogStyleSheet) {
> +                dialogStyleSheet = parseUASheet(dialogUserAgentStyleSheet, sizeof(dialogUserAgentStyleSheet));
> +                addToDefaultStyle(*dialogStyleSheet);
> +            }
> +        }

We should remember to merge this to the main stylesheet when this ships.

> Source/WebKit/Shared/WebPreferences.yaml:1889
> +    category: internal

Don't web facing things usually go to experimental?
Comment 4 Simon Fraser (smfr) 2019-12-22 13:45:50 PST 
Created attachment 386320 [details]
Patch
Comment 5 Simon Fraser (smfr) 2019-12-22 19:55:45 PST 
https://trac.webkit.org/changeset/253880/webkit
Comment 6 Radar WebKit Bug Importer 2019-12-22 19:56:17 PST 
<rdar://problem/58151097>