Bug 205543 – Very basic <dialog> show/close support

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Very basic <dialog> show/close support

[Simon Fraser (smfr)]

Created attachment 386301 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 386302 [details]
Patch

[Antti Koivisto]

Comment on attachment 386302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386302&action=review

> Source/WebCore/style/UserAgentStyle.cpp:237
> +        else if (is<HTMLDialogElement>(element) && RuntimeEnabledFeatures::sharedFeatures().dialogElementEnabled()) {
> +            if (!dialogStyleSheet) {
> +                dialogStyleSheet = parseUASheet(dialogUserAgentStyleSheet, sizeof(dialogUserAgentStyleSheet));
> +                addToDefaultStyle(*dialogStyleSheet);
> +            }
> +        }

We should remember to merge this to the main stylesheet when this ships.

> Source/WebKit/Shared/WebPreferences.yaml:1889
> +    category: internal

Don't web facing things usually go to experimental?

[Simon Fraser (smfr)]

Created attachment 386320 [details]
Patch

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/253880/webkit

[Radar WebKit Bug Importer]

<rdar://problem/58151097>