Bug 205539 - Deprecate _WKWebsitePolicies
Summary: Deprecate _WKWebsitePolicies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-21 00:11 PST by Alex Christensen
Modified: 2020-01-03 09:51 PST (History)
3 users (show)

See Also:

Attachments
Patch (38.57 KB, patch)
2019-12-21 00:14 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (38.62 KB, patch)
2020-01-02 11:40 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (38.62 KB, patch)
2020-01-02 17:38 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-12-21 00:11:54 PST 
Deprecate _WKWebsitePolicies
Comment 1 Alex Christensen 2019-12-21 00:14:35 PST 
Created attachment 386292 [details]
Patch
Comment 2 Alex Christensen 2020-01-02 11:40:56 PST 
Created attachment 386610 [details]
Patch
Comment 3 Alex Christensen 2020-01-02 17:38:27 PST 
Created attachment 386650 [details]
Patch
Comment 4 Wenson Hsieh 2020-01-03 08:50:30 PST 
Comment on attachment 386650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386650&action=review

Nice!

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-2145
> -    [self _updateWebpagePreferences:websitePolicies.webpagePreferences];

Is this change binary compatible with shipping Safari?
Comment 5 Alex Christensen 2020-01-03 08:52:52 PST 
Comment on attachment 386650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386650&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-2145
>> -    [self _updateWebpagePreferences:websitePolicies.webpagePreferences];
> 
> Is this change binary compatible with shipping Safari?

This will break a small edge-case feature in shipping Safari when using open source WebKit with it, but this is not important to open source WebKit developers.
Comment 6 WebKit Commit Bot 2020-01-03 09:49:58 PST 
The commit-queue encountered the following flaky tests while processing attachment 386650 [details]:

highlight/highlight-world-leak.html bug 205643 (author: megan_gardner@apple.com)
imported/w3c/web-platform-tests/media-source/mediasource-h264-play-starved.html bug 205728 (author: aboya@igalia.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-01-03 09:50:51 PST 
Comment on attachment 386650 [details]
Patch

Clearing flags on attachment: 386650

Committed r254005: <https://trac.webkit.org/changeset/254005>
Comment 8 WebKit Commit Bot 2020-01-03 09:50:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-01-03 09:51:18 PST 
<rdar://problem/58299901>